This repository was archived by the owner on Feb 25, 2025. It is now read-only.
First pass at adding meal tracking to fitness app #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -208,33 +164,33 @@ class HomeFragment extends StatefulComponent { | |||
| Widget buildBody() { | |||
| TextStyle style = Theme.of(this).text.title; | |||
| switch (_fitnessMode) { | |||
There was a problem hiding this comment.
shouldn't this be two classes somehow?
There was a problem hiding this comment.
yeah, it should -- will refactor in a future CL
|
LGTM. |
Conflicts: sky/sdk/example/fitness/lib/feed.dart
collinjackson
added a commit
that referenced
this pull request
Jul 22, 2015
First pass at adding meal tracking to fitness app R=hixie
aam
added a commit
to aam/engine
that referenced
this pull request
Dec 28, 2018
``` 67befc4 Fix script so it assumes some default values for host_os, host_cpu vars. (flutter#204) 262d978 Android readme (flutter#202) ```
aam
added a commit
that referenced
this pull request
Dec 28, 2018
JediBurrell
pushed a commit
to JediBurrell/engine
that referenced
this pull request
Jan 10, 2019
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
* Make Dart protobuf emite Kythe metdata. * Fix Travis tests with proper names Set. * Fix other Travis tests, update CHANGELOG and pubspec. * Remove unused _offset from IndentingWriter. * Fix whitespacing in meta goldens. * Remove default explicit null value in IndentingWriter. * Reformat test files to change line wrapping for external paths.
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
Fix issues identified by Infer
swift-kim
referenced
this pull request
in swift-kim/engine
Nov 12, 2021
* Fix vsync issue After the engine is shutdown, OnVsync no longer be called. * Add lock when call OnVsync 1.Remove lock when create TdmClient. 2.Add lock when call OnVsync. 3.Change tdmClient to tdm_client.
swift-kim
referenced
this pull request
in swift-kim/engine
Nov 15, 2021
* Fix vsync issue After the engine is shutdown, OnVsync no longer be called. * Add lock when call OnVsync 1.Remove lock when create TdmClient. 2.Add lock when call OnVsync. 3.Change tdmClient to tdm_client.
WonyoungChoi
pushed a commit
to WonyoungChoi/engine
that referenced
this pull request
Dec 14, 2021
* Fix vsync issue After the engine is shutdown, OnVsync no longer be called. * Add lock when call OnVsync 1.Remove lock when create TdmClient. 2.Add lock when call OnVsync. 3.Change tdmClient to tdm_client.
WonyoungChoi
pushed a commit
to WonyoungChoi/engine
that referenced
this pull request
Dec 23, 2021
* Fix vsync issue After the engine is shutdown, OnVsync no longer be called. * Add lock when call OnVsync 1.Remove lock when create TdmClient. 2.Add lock when call OnVsync. 3.Change tdmClient to tdm_client.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.