Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix web_ui warnings flagged by the next Dart analyzer update #20524

Merged
merged 1 commit into from
Aug 14, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/web_ui/lib/src/engine/compositor/shader.dart
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ class CkImageShader extends CkShader implements ui.ImageShader {
SkShader createDefault() => _skImage.skImage.makeShader(
toSkTileMode(tileModeX),
toSkTileMode(tileModeY),
matrix4 != null ? toSkMatrixFromFloat64(matrix4) : null,
toSkMatrixFromFloat64(matrix4),
);

@override
Expand Down
3 changes: 0 additions & 3 deletions lib/web_ui/lib/src/engine/surface/scene_builder.dart
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,6 @@ class SurfaceSceneBuilder implements ui.SceneBuilder {
Float64List matrix4, {
ui.TransformEngineLayer? oldLayer,
}) {
if (matrix4 == null) { // ignore: unnecessary_null_comparison
throw ArgumentError('"matrix4" argument cannot be null');
}
if (matrix4.length != 16) {
throw ArgumentError('"matrix4" must have 16 entries.');
}
Expand Down
3 changes: 2 additions & 1 deletion lib/web_ui/test/engine/surface/scene_builder_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ void main() {
testLayerLifeCycle((SceneBuilder sceneBuilder, EngineLayer oldLayer) {
return sceneBuilder.pushClipRRect(
RRect.fromLTRBR(10, 20, 30, 40, const Radius.circular(3)),
oldLayer: oldLayer);
oldLayer: oldLayer,
clipBehavior: Clip.none);
}, () {
return '''
<s>
Expand Down
1 change: 1 addition & 0 deletions lib/web_ui/test/text/measurement_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1157,5 +1157,6 @@ EngineLineMetrics line(
lineNumber: lineNumber,
left: left,
endIndexWithoutNewlines: -1,
widthWithTrailingSpaces: width,
);
}