This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland: Create PlatformView instance right after method channel call from Dart #20568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 17, 2020 12:46
…el call from Dart (flutter#20500)" (flutter#20564)" This reverts commit 7b9ac27.
blasten
force-pushed
the
reland_pv_order
branch
from
1f15b7e to
ed148a8
Compare
gaaclarke
approved these changes
Aug 17, 2020
| View mutatorView = mutatorViews.get(viewId); | ||
| for (int i = 0; i < platformViewParent.size(); i++) { | ||
| final int viewId = platformViewParent.keyAt(i); | ||
| final View parentView = platformViewParent.get(viewId); |
There was a problem hiding this comment.
Is it possible parentView will be null?
There was a problem hiding this comment.
It's not possible. This is iterating over the existing entries, and the code never puts null in the dictionary.
blasten
added
the
waiting for tree to go green
cyanglaz
approved these changes
Aug 17, 2020
| @@ -79,9 +79,20 @@ | |||
| // it is associated with(e.g if a platform view creates other views in the same virtual display. | |||
| private final HashMap<Context, View> contextToPlatformView; | |||
|
|
|||
| private final SparseArray<PlatformViewsChannel.PlatformViewCreationRequest> platformViewRequests; | |||
| // The view returned by `PlatformView#getView()`. | |||
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 18, 2020
…el call from Dart (flutter/engine#20568)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relands #20500
1f15b7e fixes the issue.