Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Log exception in addition to the stack trace for unhandled exceptions. #20935

Merged
merged 2 commits into from
Sep 2, 2020
Merged

Log exception in addition to the stack trace for unhandled exceptions. #20935

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35e8f5b
Log exception in addition to the stack trace for unhandled exceptions.
aam Sep 2, 2020
493f2b8
Format
aam Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion third_party/tonic/logging/dart_error.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,14 @@ const char kInvalidArgument[] = "Invalid argument.";

bool LogIfError(Dart_Handle handle) {
if (Dart_IsUnhandledExceptionError(handle)) {
Dart_Handle exception_handle = Dart_ErrorGetException(handle);
const std::string exception =
tonic::StdStringFromDart(Dart_ToString(exception_handle));
Dart_Handle stack_trace_handle = Dart_ErrorGetStackTrace(handle);
const std::string stack_trace =
tonic::StdStringFromDart(Dart_ToString(stack_trace_handle));
tonic::Log("Dart Unhandled Exception: %s", stack_trace.c_str());
tonic::Log("Dart Unhandled Exception: %s, stack trace: %s",
exception.c_str(), stack_trace.c_str());
return true;
} else if (Dart_IsError(handle)) {
tonic::Log("Dart Error: %s", Dart_GetError(handle));
Expand Down