Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Support dragging native platform views #21396

Merged
merged 3 commits into from
Sep 26, 2020
Merged

Support dragging native platform views #21396

merged 3 commits into from
Sep 26, 2020

Conversation

@blasten
Copy link

@blasten blasten commented Sep 25, 2020

Description

Moving a scroll-view by pressing a platform view causes the scroll-view to jump.

Steps to reproduce the behavior:

  1. Press a platform view and start scrolling
  2. Scroll-view jumps forwards and backwards

Related Issues

flutter/flutter#31243

Tests

Unit tests

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

@blasten blasten requested a review from iskakaushik September 25, 2020 02:45
@auto-assign auto-assign bot requested a review from gaaclarke September 25, 2020 02:45
@blasten blasten requested review from jason-simmons and removed request for gaaclarke September 25, 2020 02:45
@blasten blasten added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Sep 25, 2020
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Mac iOS Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Sep 25, 2020
@blasten blasten merged commit db99912 into flutter:master Sep 26, 2020
@blasten blasten deleted the drag_view branch September 26, 2020 00:46
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 26, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 26, 2020
@engine-flutter-autoroll
db99912 Support dragging native platform views (flutter/engine#21396)
66a97f0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 26, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 26, 2020
@engine-flutter-autoroll
db99912 Support dragging native platform views (flutter/engine#21396)
5da1e54
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 26, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 26, 2020
@engine-flutter-autoroll
db99912 Support dragging native platform views (flutter/engine#21396)
819a657
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 26, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 26, 2020
@engine-flutter-autoroll
db99912 Support dragging native platform views (flutter/engine#21396)
59f53bb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 26, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 26, 2020
@engine-flutter-autoroll
db99912 Support dragging native platform views (flutter/engine#21396)
f883689
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 26, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 26, 2020
@engine-flutter-autoroll
db99912 Support dragging native platform views (flutter/engine#21396)
ad88247
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 26, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 26, 2020
@engine-flutter-autoroll
db99912 Support dragging native platform views (flutter/engine#21396)
151a818
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 26, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 26, 2020
@engine-flutter-autoroll
db99912 Support dragging native platform views (flutter/engine#21396)
31bf601
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 27, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 27, 2020
@engine-flutter-autoroll
db99912 Support dragging native platform views (flutter/engine#21396)
b047af5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 27, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 27, 2020
@engine-flutter-autoroll
db99912 Support dragging native platform views (flutter/engine#21396)
99bfb51
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 27, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 27, 2020
@engine-flutter-autoroll
db99912 Support dragging native platform views (flutter/engine#21396)
279c8e9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 27, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 27, 2020
@engine-flutter-autoroll
db99912 Support dragging native platform views (flutter/engine#21396)
33fe015
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 27, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 27, 2020
@engine-flutter-autoroll
db99912 Support dragging native platform views (flutter/engine#21396)
9764fe9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 27, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 27, 2020
@engine-flutter-autoroll
db99912 Support dragging native platform views (flutter/engine#21396)
356f097
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 28, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 28, 2020
@engine-flutter-autoroll
db99912 Support dragging native platform views (flutter/engine#21396)
40c6ead
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 28, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 28, 2020
@engine-flutter-autoroll
db99912 Support dragging native platform views (flutter/engine#21396)
2819a0d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 28, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 28, 2020
@engine-flutter-autoroll
db99912 Support dragging native platform views (flutter/engine#21396)
c3d1800
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 28, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 28, 2020
@engine-flutter-autoroll
db99912 Support dragging native platform views (flutter/engine#21396)
cd54958
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 28, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 28, 2020
@engine-flutter-autoroll
db99912 Support dragging native platform views (flutter/engine#21396)
81b0e97
dnfield pushed a commit to flutter/flutter that referenced this pull request Sep 28, 2020
@engine-flutter-autoroll
Roll Engine from 3a73d07 to 8d165fa (45 revisions) (#66840)
cb3de6f 
* a1db2b3 Roll Fuchsia Linux SDK from NeYDIjo58... to BFLXvCMVi... (flutter/engine#21403)

* faeff0a Roll Dart SDK from eb8e6232da02 to 13b3f2d7b6ea (3 revisions) (flutter/engine#21407)

* 7dfcde1 [Fix] Replaces call to deprecated method Name.name. (flutter/engine#21241)

* 48ab5d1 Roll Skia from 1748c6a3b8c8 to 3b88c0772e89 (1 revision) (flutter/engine#21410)

* aa8d5d4 Avoid sending a 0 DPR to framework (flutter/engine#21389)

* 67fdd7e Embedder API Support for display settings (flutter/engine#21355)

* 1fc87c0 Roll Skia from 3b88c0772e89 to d7ab45027877 (1 revision) (flutter/engine#21411)

* de5f2b4 Revert "Revert "Adds fuchsia node roles to accessibility bridge updates. (#20385)" (#20936)" (flutter/engine#21367)

* c9b40c6 Remove ASCII art from mDNS error log (flutter/engine#21397)

* fed0531 Roll Fuchsia Mac SDK from xnB_uJM8T... to _e0onA6gY... (flutter/engine#21414)

* d877b83 [web] enable ios safari screenshot tests (flutter/engine#21226)

* a8f52e5 Roll Skia from d7ab45027877 to aeae3a58e3da (6 revisions) (flutter/engine#21415)

* 8275609 Roll Skia from aeae3a58e3da to 7bd60430299f (1 revision) (flutter/engine#21417)

* 65c1122 Roll Dart SDK from 13b3f2d7b6ea to 4fb134a228c7 (2 revisions) (flutter/engine#21419)

* d735f2c Roll Fuchsia Linux SDK from BFLXvCMVi... to XcAUWQUZm... (flutter/engine#21420)

* f1961e5 Roll Skia from 7bd60430299f to 68861e391313 (14 revisions) (flutter/engine#21421)

* 08cf725 Fix getNextFrame (flutter/engine#21422)

* db99912 Support dragging native platform views (flutter/engine#21396)

* df83e8f Roll Skia from 68861e391313 to a05d27b170ee (1 revision) (flutter/engine#21424)

* fc7d0fc [web] Respond with null for unimplemented method channels (flutter/engine#21423)

* 02b8567 Roll Skia from a05d27b170ee to 5e1545fa00c8 (1 revision) (flutter/engine#21425)

* 6e54e68 Roll Dart SDK from 4fb134a228c7 to db7eb2549480 (1 revision) (flutter/engine#21426)

* b0cd7d1 Roll Dart SDK from db7eb2549480 to 200e8da5072a (1 revision) (flutter/engine#21427)

* 0de5c0c Roll Fuchsia Linux SDK from XcAUWQUZm... to 0nW5DAxcC... (flutter/engine#21430)

* 854943d [macOS] Set the display refresh rate (flutter/engine#21095)

* 11aecf4 Roll Skia from 5e1545fa00c8 to 766eeb2ac325 (1 revision) (flutter/engine#21431)

* b8e2b3f Roll Skia from 766eeb2ac325 to 5648572f4a94 (1 revision) (flutter/engine#21433)

* 33d0bbb Roll Fuchsia Mac SDK from _e0onA6gY... to SUSVNJcX5... (flutter/engine#21434)

* 51049d2 Roll Skia from 5648572f4a94 to eabce08bb2f2 (1 revision) (flutter/engine#21435)

* a491533 Roll Dart SDK from 200e8da5072a to c938793e2d6f (1 revision) (flutter/engine#21437)

* 06398b8 Roll Fuchsia Linux SDK from 0nW5DAxcC... to xdxm8rU8b... (flutter/engine#21439)

* 4282bbc Roll Dart SDK from c938793e2d6f to fe83360d3a7c (1 revision) (flutter/engine#21440)

* eba7b8e Roll Fuchsia Mac SDK from SUSVNJcX5... to v5Ko06GkT... (flutter/engine#21441)

* 249bcf7 Roll Fuchsia Linux SDK from xdxm8rU8b... to ej-CkfSra... (flutter/engine#21443)

* 4422ede Roll Fuchsia Mac SDK from v5Ko06GkT... to k_lSjZxIH... (flutter/engine#21445)

* 35fa4bb Roll Dart SDK from fe83360d3a7c to 44e4f3958019 (1 revision) (flutter/engine#21446)

* a9b5b13 Roll Fuchsia Linux SDK from ej-CkfSra... to HNNs4gfuM... (flutter/engine#21447)

* 4f7ff21 Roll Skia from eabce08bb2f2 to ad6aeace6eee (2 revisions) (flutter/engine#21448)

* f72613d Roll Dart SDK from 44e4f3958019 to e2a4eaba73b8 (1 revision) (flutter/engine#21451)

* 2917a65 [ios] Remove unused is_valid_ from IOS Metal Context (flutter/engine#21432)

* b591674 Roll Dart SDK from e2a4eaba73b8 to 13deada5b267 (1 revision) (flutter/engine#21453)

* a07e0e0 Roll Fuchsia Mac SDK from k_lSjZxIH... to qyoO7f9Sk... (flutter/engine#21454)

* cf1fbf2 Apply dpr transform to fuchsia accessibility bridge (flutter/engine#21364)

* 9db9a57 Revert "Apply dpr transform to fuchsia accessibility bridge (#21364)" (flutter/engine#21458)

* 8d165fa Revert multiple display support for embedder API (flutter/engine#21456)
christopherfujino added a commit that referenced this pull request Sep 28, 2020
@christopherfujino
Flutter 1.22.0-12.3.pre engine cherrypicks (#21466)
5babba6 
* Update dart to 2.10.0
* Support dragging native platform views (#21396)

Co-authored-by: Emmanuel Garcia <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@iskakaushik iskakaushik iskakaushik approved these changes

@jason-simmons jason-simmons jason-simmons approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@blasten @fluttergithubbot @iskakaushik @jason-simmons @googlebot