Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Run desktop darwin tests in debug mode #21660

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Run desktop darwin tests in debug mode #21660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions shell/platform/darwin/macos/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,8 @@ executable("flutter_desktop_darwin_unittests") {

cflags_objcc = [ "-fobjc-arc" ]

ldflags = [ "-ObjC" ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was implicit. The default rules should have already been building this target and would have failed linking without this flag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why it was needed, i'm going to leave it here since it shouldn't create additional problems.


deps = [
":flutter_desktop_darwin_fixtures",
":flutter_framework_source",
Expand Down
5 changes: 5 additions & 0 deletions testing/run_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,11 @@ def RunCCTests(build_dir, filter):
if IsMac():
RunEngineExecutable(build_dir, 'flutter_channels_unittests', filter, shuffle_flags)

# These tests can only be run on Darwin on debug mode.
# See: https://github.com/flutter/flutter/issues/66664
if IsMac() and ('debug' in build_dir):
RunEngineExecutable(build_dir, 'flutter_desktop_darwin_unittests', filter, shuffle_flags)

# https://github.com/flutter/flutter/issues/36296
if IsLinux():
RunEngineExecutable(build_dir, 'txt_unittests', filter, shuffle_flags)
Expand Down