This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Update const finder test to match the new signature shaker #22149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to land this we would need to do a manual Dart -> Engine roll as well. Since you might be OOO already, I've combined this PR with the manual roll changes in: #22153. If that goes green we can land it to unbreak the auto roller. |
|
LGTM, also LGTM'd the roll that contains it. |
|
Landed as part of #22153 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the const finder test to match the new Dart AOT signature shaker optimization that was landed in https://dart.googlesource.com/sdk/+/23ee425de7533bab8e55957377dbf9e407609df6.