Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[embedder] FlutterBackingStoreConfig allows special treatment of root-views #22642

Closed
wants to merge 1 commit into from

Conversation

iskakaushik
Copy link
Contributor

No description provided.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Nov 20, 2020
Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With custom composition, there is no such thing as a root view/surface (I believe documentation even states that). I am not sure what use case there is for this in the public API?

@iskakaushik
Copy link
Contributor Author

@RichardJCai we have a stable ordering for the layers. We can safely assume that the first layer is indeed the root-layer. We do not need this PR.

@RichardJCai
Copy link
Contributor

Hey @chinmaygarde, the reason we wanted this is because when creating a backing store for the first layer, we wanted to be able to re-use to fbos provided by FlutterSurfaceManager (to use current behaviour / prevent regressions).

The is_root_view lets us know when CreateBackingStore is called if the layer is the first one or not. I think we still want to be able to know if the layer requesting the backing store is the first layer. Do you have any suggestions on how to do this or if this is even the right approach?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants