This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] sharding change is merged. re-enable tests #22884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
nturgut
commented
Dec 4, 2020
| 'text_editing_integration.dart', | ||
| 'treeshaking_integration.dart', | ||
| 'url_strategy_integration.dart', | ||
| ], |
There was a problem hiding this comment.
@yjbanov @hterkelsen is it useful to have these? I can also keep this list and not run these tests if we think html+canvaskit is enough?
ferhatb
approved these changes
Dec 8, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to timeouts on the Linux Web Engine builder we closed many tests in the last week:
https://github.com/flutter/engine/pull/22846/files
#22824
Since the recipe changes are merged to enable sharding for LWE (design: go/web-engine-recipe-drones)
https://flutter-review.googlesource.com/c/recipes/+/9120
https://flutter-review.googlesource.com/c/recipes/+/8980
We can re-enable these tests.
Fixes: flutter/flutter#71583