Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix engine in preparation for implementing https://github.com/dart-lang/language/issues/1274 #23131

Merged
merged 1 commit into from
Dec 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/web_ui/lib/src/engine/html/surface.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1092,7 +1092,17 @@ abstract class PersistedContainerSurface extends PersistedSurface {
for (int indexInOld = 0; indexInOld < oldChildCount; indexInOld += 1) {
final PersistedSurface? oldChild = oldChildren[indexInOld];
final bool childAlreadyClaimed = oldChild == null;
if (childAlreadyClaimed || !newChild.canUpdateAsMatch(oldChild!)) {
// After https://github.com/dart-lang/language/issues/1274 is
// implemented, `oldChild` will be promoted to non-nullable on the RHS
// of the `||`, so we won't need to null check it (and it will cause a
// build failure to try to do so). Until then, we need to null check it
// in such a way that won't cause a build failure once the feature is
// implemented. We can do that by casting to `dynamic`, and then
// relying on the call to `canUpdateAsMatch` implicitly downcasting to
// PersistentSurface.
// TODO(paulberry): remove this workaround once the feature is
// implemented.
if (childAlreadyClaimed || !newChild.canUpdateAsMatch(oldChild as dynamic)) {
continue;
}
allMatches.add(_PersistedSurfaceMatch(
Expand Down
12 changes: 11 additions & 1 deletion lib/web_ui/lib/src/engine/semantics/semantics.dart
Original file line number Diff line number Diff line change
Expand Up @@ -889,7 +889,17 @@ class SemanticsObject {
effectiveTransformIsIdentity = effectiveTransform.isIdentity();
}
} else if (!hasIdentityTransform) {
effectiveTransform = Matrix4.fromFloat32List(transform!);
// After https://github.com/dart-lang/language/issues/1274 is implemented,
// `transform` will be promoted to non-nullable so we won't need to null
// check it (and it will cause a build failure to try to do so). Until
// then, we need to null check it in such a way that won't cause a build
// failure once the feature is implemented. We can do that using an
// explicit "if" test.
// TODO(paulberry): remove this check once the feature is implemented.
if (transform == null) { // ignore: unnecessary_null_comparison
throw 'impossible';
}
effectiveTransform = Matrix4.fromFloat32List(transform);
effectiveTransformIsIdentity = false;
}

Expand Down