This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Add missing static binding check. #23731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is something I missed while adding the mew method in flutter#23128. Bug: flutter/flutter#72321
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
approved these changes
Jan 16, 2021
zanderso
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 16, 2021
gspencergoog
pushed a commit
to gspencergoog/engine
that referenced
this pull request
Jan 20, 2021
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
naturallymitchell
pushed a commit
to naturallymitchell/fuchsia
that referenced
this pull request
May 23, 2022
This was previously landed as fxr/470757 but reverted because Flutter engine was missing a mapping for clockGetMonotonic. That fix landed upstream in flutter/engine#23731. Bug: 66266 Change-Id: I8ced72ac42489e1fd718cf4595ac417d02c5fda2 Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/479161 Reviewed-by: Chase Latta <[email protected]> Commit-Queue: Jody Sankey <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: flutter/flutter#72321
This mapping table is something I missed while adding the new clockGetMonotonic method in #23128.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.