Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove meaningless judgments for gpu task when raster and platform are not same thread #25583

Closed

Conversation

kinarobin
Copy link

@kinarobin kinarobin commented Apr 14, 2021

From flutter/flutter#16068, Always make gpu thread different from platform thread regardless of platform view.

And raster thread merger flutter/flutter#19919.

the raster and platform are not same thread. so should_post_raster_task is meaningless.

Don't need test.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Apr 14, 2021
@kinarobin kinarobin force-pushed the remove-judgment-for-gpu-task branch from 88850ef to 30cc9dc Compare April 14, 2021 13:05
@kinarobin kinarobin closed this Apr 15, 2021
@kinarobin kinarobin deleted the remove-judgment-for-gpu-task branch April 15, 2021 06:43
@kinarobin kinarobin restored the remove-judgment-for-gpu-task branch April 15, 2021 08:45
@kinarobin kinarobin reopened this Apr 15, 2021
@flutter-dashboard flutter-dashboard bot added the embedder Related to the embedder API label Apr 15, 2021
@kinarobin kinarobin closed this Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes embedder Related to the embedder API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant