This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use a comma-separated args string for UWP #26110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UWP apps get a single arguments string on launch rather than an array. The current implementation splits that args string on commas. This updates the UWP launch args generation to match. Part of flutter/flutter#81756 Part of flutter/flutter#82085
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 13, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 13, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 13, 2021
cbracken
pushed a commit
to flutter/flutter
that referenced
this pull request
May 13, 2021
* 67b046e Update documentation for embedding SplashScreen (flutter/engine#25943) * a0a7203 Set exitcode to 0 on successful uwptool launch (flutter/engine#26105) * ecb367f Roll Skia from 0270bf5d10be to 4e9d5e2bdf04 (5 revisions) (flutter/engine#26102) * 85bcce7 Roll Dart SDK from 934cc986926d to 171876a4e6cf (2 revisions) (flutter/engine#26101) * b99a362 Roll Fuchsia Mac SDK from GNyjTge9c... to q1qWG9XiN... (flutter/engine#26107) * f7c3e7e Added exception if you try to reply with a non-direct ByteBuffer. (flutter/engine#25952) * 96ec5a5 Roll Skia from 4e9d5e2bdf04 to 84f70136abfb (4 revisions) (flutter/engine#26108) * 2c3c1df Use a comma-separated args string for UWP (flutter/engine#26110) * 25c06a4 Roll Skia from 84f70136abfb to 66441d4ea0fa (2 revisions) (flutter/engine#26111) * d21a04b Roll Skia from 66441d4ea0fa to 537b7508343d (1 revision) (flutter/engine#26113) * aeb98f4 Roll Fuchsia Linux SDK from MoY7UVVro... to WYD7atCH7... (flutter/engine#26116) * 08d9bc0 Revert "Sped up the objc standard message codec (#25998)" (flutter/engine#26117)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UWP apps get a single arguments string on launch rather than an array.
The current implementation splits that args string on commas. This
updates the UWP launch args generation to match.
Part of flutter/flutter#81756
Part of flutter/flutter#82085
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.