This repository was archived by the owner on Feb 25, 2025. It is now read-only.
fixes crash when sets mouseTrackingMode before view is loaded #26576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
reviewed
Jun 4, 2021
| @@ -396,7 +396,9 @@ - (void)listenForMetaModifiedKeyUpEvents { | |||
| } | |||
|
|
|||
| - (void)configureTrackingArea { | |||
| NSAssert(self.viewLoaded, @"View must be loaded before setting tracking area"); | |||
| if (!self.viewLoaded) { | |||
| return; | |||
There was a problem hiding this comment.
What causes this to get set again when the view loads?
There was a problem hiding this comment.
- (void)viewDidLoad; will call the configureTrackingArea selector
There was a problem hiding this comment.
cool - maybe just mention that here in a comment? otherwise LGTM
dnfield
approved these changes
Jun 4, 2021
chunhtai
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 6, 2021
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression introduced by my previous pr #25600 where i add more assert around flutterview usage.
fixes flutter/flutter#83933
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.