Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Android lint to NNBD #26826

Merged
merged 1 commit into from
Jun 20, 2021
Merged

Android lint to NNBD #26826

merged 1 commit into from
Jun 20, 2021

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Jun 18, 2021

See #23151 for context

Fixes flutter/flutter#72542

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Jun 18, 2021
@Hixie
Copy link
Contributor

Hixie commented Jun 18, 2021

test-exempt: refactor with no semantic change

@dnfield dnfield merged commit 1eb8a34 into flutter:master Jun 20, 2021
@dnfield dnfield deleted the android_lint_nnbd branch June 20, 2021 13:58
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 20, 2021
Copy link

@hamad22h hamad22h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@hamad22h hamad22h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -2,11 +2,227 @@
// Use of this source code is governed by a BSD-style license that can be

This comment was marked as spam.

wqyfavor pushed a commit to wqyfavor/engine that referenced this pull request Jun 21, 2021
moffatman pushed a commit to moffatman/engine that referenced this pull request Aug 5, 2021
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate the deps of the Engine's android_lint script
4 participants