This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add missing context switches in Rasterizer #26847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knopp
changed the title
knopp
force-pushed
the
rasterizer_wrong_glcontexts
branch
from
a5754c1 to
c3b2324
Compare
knopp
changed the title
chinmaygarde
approved these changes
Jun 20, 2021
knopp
force-pushed
the
rasterizer_wrong_glcontexts
branch
from
c3b2324 to
135a30a
Compare
knopp
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 20, 2021
wqyfavor
pushed a commit
to wqyfavor/engine
that referenced
this pull request
Jun 21, 2021
moffatman
pushed a commit
to moffatman/engine
that referenced
this pull request
Aug 5, 2021
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
dnfield
reviewed
Jun 2, 2022
Comment on lines
+151
to
+154
| auto context_switch = surface_->MakeRenderContextCurrent(); | ||
| if (!context_switch->GetResult()) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
I think this might be wrong.
This means that if the OS sends a low memory warning, we will fail to clear the cache if we're unable to make the context current. This will result in the OS killing us or some other process(es), particularly on mobile/Fuchsia/CastOS.
If we're running low on memory, we should unconditionally purge the resource cache. This will not result in context corruption, though it may slow down next frames.
There was a problem hiding this comment.
Filed flutter/flutter#105192 to discuss
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#84930
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.