Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Do not generate keydown event for empty modifier flags #27817

Merged
merged 6 commits into from
Jul 31, 2021
Merged

Do not generate keydown event for empty modifier flags #27817

merged 6 commits into from
Jul 31, 2021

Conversation

knopp
Copy link
Member

@knopp knopp commented Jul 30, 2021

Fixes flutter/flutter#87339

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Jul 30, 2021
@knopp knopp requested a review from dkwingsmt July 30, 2021 20:11
@knopp knopp force-pushed the no_event_on_empty_modifier_flags branch from 1197c82 to 01eddfa Compare July 30, 2021 23:24
@knopp knopp force-pushed the no_event_on_empty_modifier_flags branch from 01eddfa to 388aaf7 Compare July 30, 2021 23:31
dkwingsmt
dkwingsmt approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with doc suggestion

@dkwingsmt dkwingsmt merged commit 9f175fd into flutter:master Jul 31, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2021
@engine-flutter-autoroll
9f175fd Do not generate keydown event for empty modifier flags (flutt…
ab9e005 
…er/engine#27817)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2021
@engine-flutter-autoroll
9f175fd Do not generate keydown event for empty modifier flags (flutt…
f993d15 
…er/engine#27817)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2021
@engine-flutter-autoroll
9f175fd Do not generate keydown event for empty modifier flags (flutt…
a1ca7c4 
…er/engine#27817)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2021
@engine-flutter-autoroll
9f175fd Do not generate keydown event for empty modifier flags (flutt…
7cd9230 
…er/engine#27817)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2021
@engine-flutter-autoroll
9f175fd Do not generate keydown event for empty modifier flags (flutt…
02aae2b 
…er/engine#27817)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 1, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 1, 2021
@engine-flutter-autoroll
9f175fd Do not generate keydown event for empty modifier flags (flutt…
62e7ec1 
…er/engine#27817)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 1, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 1, 2021
@engine-flutter-autoroll
9f175fd Do not generate keydown event for empty modifier flags (flutt…
ccc35a0 
…er/engine#27817)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 2, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 2, 2021
@engine-flutter-autoroll
9f175fd Do not generate keydown event for empty modifier flags (flutt…
20f96b1 
…er/engine#27817)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 2, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 2, 2021
@engine-flutter-autoroll
9f175fd Do not generate keydown event for empty modifier flags (flutt…
8547496 
…er/engine#27817)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 2, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 2, 2021
@engine-flutter-autoroll
9f175fd Do not generate keydown event for empty modifier flags (flutt…
7a28262 
…er/engine#27817)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 2, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 2, 2021
@engine-flutter-autoroll
9f175fd Do not generate keydown event for empty modifier flags (flutt…
695247b 
…er/engine#27817)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 3, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2021
@engine-flutter-autoroll
9f175fd Do not generate keydown event for empty modifier flags (flutt…
873c8d8 
…er/engine#27817)
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
@knopp
Do not generate keydown event for empty modifier flags (flutter#27817)
ea95adf 
* Do not generate keydown event for empty modifier flags

* Mask 0x100 bit instead of comparison

* Comment

* Update comment

* comment

* Add comment
@dkwingsmt dkwingsmt mentioned this pull request Sep 16, 2021
Merged
8 tasks
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
@knopp @filmil
Do not generate keydown event for empty modifier flags (flutter#27817)
ab4d9a9 
* Do not generate keydown event for empty modifier flags

* Mask 0x100 bit instead of comparison

* Comment

* Update comment

* comment

* Add comment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Assignees
No one assigned
Labels
cla: yes platform-macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

macOS: Should never encounter KeyData when transitMode is rawKeyData.
2 participants
@knopp @dkwingsmt