Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Migrate Flutter Web DOM usage to JS static interop - 31. #33361

Merged
merged 2 commits into from
Jun 15, 2022
Merged

[web] Migrate Flutter Web DOM usage to JS static interop - 31. #33361

merged 2 commits into from
Jun 15, 2022

Conversation

joshualitt
Copy link
Contributor

This is CL 31 in a series of CLs to migrate Flutter Web DOM usage to the new JS static interop API.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label May 15, 2022
@skia-gold
Copy link

Gold has detected about 20 new digest(s) on patchset 22.
View them at https://flutter-engine-gold.skia.org/cl/github/33361

eyebrowsoffire
eyebrowsoffire approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicks on formatting.

@joshualitt joshualitt force-pushed the html_31 branch 2 times, most recently from 0ca18bb to 11e64a3 Compare June 13, 2022 23:40
@joshualitt joshualitt marked this pull request as ready for review June 13, 2022 23:40
@joshualitt joshualitt merged commit ae357ca into flutter:main Jun 15, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
ae357ca [web] Migrate Flutter Web DOM usage to JS static interop - 31. (
839bc5a 
flutter/engine#33361)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
ae357ca [web] Migrate Flutter Web DOM usage to JS static interop - 31. (
e3dcb62 
flutter/engine#33361)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
ae357ca [web] Migrate Flutter Web DOM usage to JS static interop - 31. (
2a0fb04 
flutter/engine#33361)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
ae357ca [web] Migrate Flutter Web DOM usage to JS static interop - 31. (
95109ae 
flutter/engine#33361)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 15, 2022
@engine-flutter-autoroll
ae357ca [web] Migrate Flutter Web DOM usage to JS static interop - 31. (
6e4d154 
flutter/engine#33361)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
ae357ca [web] Migrate Flutter Web DOM usage to JS static interop - 31. (
0c99133 
flutter/engine#33361)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
ae357ca [web] Migrate Flutter Web DOM usage to JS static interop - 31. (
e5897b1 
flutter/engine#33361)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
ae357ca [web] Migrate Flutter Web DOM usage to JS static interop - 31. (
010dad8 
flutter/engine#33361)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
ae357ca [web] Migrate Flutter Web DOM usage to JS static interop - 31. (
029668b 
flutter/engine#33361)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
ae357ca [web] Migrate Flutter Web DOM usage to JS static interop - 31. (
5408a76 
flutter/engine#33361)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
ae357ca [web] Migrate Flutter Web DOM usage to JS static interop - 31. (
40bdde5 
flutter/engine#33361)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
ae357ca [web] Migrate Flutter Web DOM usage to JS static interop - 31. (
fd02683 
flutter/engine#33361)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
ae357ca [web] Migrate Flutter Web DOM usage to JS static interop - 31. (
697e0ab 
flutter/engine#33361)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
ae357ca [web] Migrate Flutter Web DOM usage to JS static interop - 31. (
51116a6 
flutter/engine#33361)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
ae357ca [web] Migrate Flutter Web DOM usage to JS static interop - 31. (
ec9c844 
flutter/engine#33361)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
ae357ca [web] Migrate Flutter Web DOM usage to JS static interop - 31. (
8e1771e 
flutter/engine#33361)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
ae357ca [web] Migrate Flutter Web DOM usage to JS static interop - 31. (
96f2408 
flutter/engine#33361)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
ae357ca [web] Migrate Flutter Web DOM usage to JS static interop - 31. (
ff1a647 
flutter/engine#33361)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
ae357ca [web] Migrate Flutter Web DOM usage to JS static interop - 31. (
d480145 
flutter/engine#33361)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
ae357ca [web] Migrate Flutter Web DOM usage to JS static interop - 31. (
ebdf298 
flutter/engine#33361)
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
@joshualitt @houhuayong
[web] Migrate Flutter Web DOM usage to JS static interop - 31. (flutt…
e603819 
…er#33361)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eyebrowsoffire eyebrowsoffire eyebrowsoffire approved these changes

Assignees
No one assigned
Labels
platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshualitt @skia-gold @eyebrowsoffire