Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Added flag to disable the dart profiler on iOS #33907

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Added flag to disable the dart profiler on iOS #33907

merged 1 commit into from
Jun 8, 2022

Conversation

gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Jun 8, 2022 •
edited
Loading

issue: flutter/flutter#105152

I don't think this PR fixes that issue, but it unblocks me from my profiling work.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke requested a review from zanderso June 8, 2022 18:25
@gaaclarke gaaclarke changed the title Added flag to disable the dart proflier. Added flag to disable the dart profiler on iOS Jun 8, 2022
@gaaclarke gaaclarke added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 8, 2022
@fluttergithubbot fluttergithubbot merged commit a205adc into flutter:main Jun 8, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 8, 2022
@engine-flutter-autoroll
a205adc Added flag to disable the dart profiler on iOS (flutter/engin…
fcef20a 
…e#33907)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 8, 2022
@engine-flutter-autoroll
a205adc Added flag to disable the dart profiler on iOS (flutter/engin…
307f0fa 
…e#33907)
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
@gaaclarke @houhuayong
Added flag to disable the dart profiler on iOS (flutter#33907)
cd38db3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zanderso zanderso zanderso approved these changes

Assignees
No one assigned
Labels
platform-ios waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaaclarke @zanderso @fluttergithubbot