This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
iOS Accessibility: during layout change, only specify the focus object when it is changed. #33972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @chunhtai so you are aware of this change when you are back from your OOO :) |
ios_delegate_->PostAccessibilityNotification( | ||
UIAccessibilityLayoutChangedNotification, | ||
FindNextFocusableIfNecessary().nativeAccessibility); | ||
(routeChanged || next != lastFocused) ? next : NULL); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be next.nativeAccessibility
instead of next
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, ptal
hellohuanlin
approved these changes
Jun 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 15, 2022
…us object when it is changed. (flutter/engine#33972)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 15, 2022
…us object when it is changed. (flutter/engine#33972)
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 15, 2022
…us object when it is changed. (flutter/engine#33972)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 15, 2022
…us object when it is changed. (flutter/engine#33972)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 15, 2022
…us object when it is changed. (flutter/engine#33972)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2022
…us object when it is changed. (flutter/engine#33972)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2022
…us object when it is changed. (flutter/engine#33972)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2022
…us object when it is changed. (flutter/engine#33972)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2022
…us object when it is changed. (flutter/engine#33972)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2022
…us object when it is changed. (flutter/engine#33972)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2022
…us object when it is changed. (flutter/engine#33972)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2022
…us object when it is changed. (flutter/engine#33972)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2022
…us object when it is changed. (flutter/engine#33972)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2022
…us object when it is changed. (flutter/engine#33972)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2022
…us object when it is changed. (flutter/engine#33972)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2022
…us object when it is changed. (flutter/engine#33972)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2022
…us object when it is changed. (flutter/engine#33972)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 17, 2022
…us object when it is changed. (flutter/engine#33972)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 17, 2022
…us object when it is changed. (flutter/engine#33972)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 17, 2022
…us object when it is changed. (flutter/engine#33972)
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
…t when it is changed. (flutter#33972)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
platform-ios
waiting for tree to go green
This PR is approved and tested, but waiting for the tree to be green to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently always specifies a new item to focus when layout changed. It adds a redundant focus request and sometimes mess up the focus if the accessibility focus is changed right before the layout change notification is handled.
See details in: flutter/flutter#104176 (comment)
Fixes: flutter/flutter#104176
I manually tested, this fix doesn't regress flutter/flutter#80991
This PR also will fix flutter/flutter#93030 and we can remove the workaround we had for 93030
Pre-launch Checklist
writing and running engine tests.
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.