Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Jun 30, 2022

This PR fixes the logic to derive logical keys by checking a "special key mapping" first, fixing flutter/flutter#106407.

This logic has long been applied to RawKeyboardIos (here) but was somehow missing in the embedding implementation. The iOS key event uses some literal strings such as "UIKeyInputEscape" as characters for certain special keys.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@dupuchba
Copy link

dupuchba commented Jul 1, 2022

Minor precision on the label, it's not only the text-input that is affected but the whole application. If you press escape (cmd+.) it will crash all apps even without any text-field

@dkwingsmt
Copy link
Contributor Author

Minor precision on the label, it's not only the text-input that is affected but the whole application. If you press escape (cmd+.) it will crash all apps even without any text-field

Don't worry, I'm just marking everything related to keyboard with text-input for me to easily group.

@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 6, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 6, 2022

  • The status or check suite Linux Android AOT Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 6, 2022
@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 6, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 7, 2022

  • The status or check suite Mac Unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2022
@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 7, 2022

  • The status or check suite Mac Unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2022
@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 7, 2022

  • The status or check suite Mac Unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants