This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Use git exec candidate list on all platforms for build" #34844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bc87d30.
loic-sharma
requested review from
cbracken,
zanderso,
gspencergoog and
yaakovschectman
loic-sharma
added
the
autosubmit
loic-sharma
commented
Jul 22, 2022
| raise IOError(f"Looks like GIT is not on the path. Tried '{candidates}'") | ||
| if IsWindows(): | ||
| git = 'git.bat' | ||
| githooks = os.path.join(githooks, 'windows') |
There was a problem hiding this comment.
This is the line that causes the issue: it shouldn't be updated before the non-Windows pre-push githook is fixed to work on Windows.
There was a problem hiding this comment.
The non-Windows pre-push works perfectly on Windows since forever, the issue is with python executable discovery / requirement as the main pre-push is a python script.
Edit: Leaving this comment for my reference and for whoever comes around looking back.
yaakovschectman
approved these changes
Jul 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #34294 to fix flutter/flutter#108122.
This change incorrectly moves the pre-push githook to the non-Windows hook, thereby breaking
git pushon Windows./cc @mtolmacs