This repository was archived by the owner on Feb 25, 2025. It is now read-only.
create a DlCanvas class and a DlCanvas->SkCanvas adapter #35774
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#109578
Introduces a new DlCanvas pure virtual API class that mirrors SkCanvas and provides a common API for talking to either an SkCanvas (through an adapter) or a DisplayListBuilder (which already was implementing it natively).
The new API will allow us to use a single DlCanvas pointer in PaintContext for data-loss-less rendering whether we are talking directly to Skia (the current default for all Flutter apps) or to Impeller.
An adapter is provided to express the DlCanvas calls to a wrapped SkCanvas.
DisplayListBuilder already provided all of these methods and so it now declares that it inherits from the new API class to provide the common API ground.
TBD: