[Impeller] Always convert std::filesystem paths in ImpellerC to UTF-8 strings #36158
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jason-simmons
force-pushed
the
bug_107590
branch
from
f543556 to
5675267
Compare
FML filesystem functions assume UTF-8, but the default string encoding on platforms such as Windows may be something else Fixes flutter/flutter#107590
jason-simmons
force-pushed
the
bug_107590
branch
from
5675267 to
37c6a99
Compare
jason-simmons
added
the
autosubmit
|
Great! Please file a CP request for this https://github.com/flutter/flutter/issues/new?assignees=&labels=cp%3A+review&template=7_cherry_pick.yml&title=%5BCP%5D+%3Ctitle%3E. |
chinmaygarde
changed the title
FML filesystem functions assume UTF-8, but the default string encoding on platforms such as Windows may be something else
Fixes flutter/flutter#107590