Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Multiwindow] Backing store and compositor #36452

Closed
wants to merge 14 commits into from

Conversation

dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Sep 27, 2022

This PR is based on #36392 and currently contains parent PRs . See dkwingsmt#8 for net changes.

This PR turns backing store and compositor to fitting the multi-view world. The change stops at:

  • Rasterizer::SubmitFrame, where it will expect a view ID from LayerTree but uses a fake one for now.
  • macos/FlutterEngine, where it should pick a viewController based on surface ID, but it only has one view controller for now.

This PR makes non-trivial changes to the embedder API:

  • A new function AddRenderSurface.
  • Deprecates FlutterCompositor.present_layers_callback, adds FlutterCompositor.present_layers_view_callback.
  • Adds FlutterBackingStoreConfig.view_id.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@dkwingsmt dkwingsmt force-pushed the backing-store-and-compositor branch 2 times, most recently from 7cb5d5a to fce69d0 Compare September 28, 2022 04:01
@dkwingsmt dkwingsmt force-pushed the backing-store-and-compositor branch from fce69d0 to 6155d81 Compare October 2, 2022 22:50
@dkwingsmt dkwingsmt self-assigned this Nov 3, 2022
@dkwingsmt
Copy link
Contributor Author

Closed in favor for #37391.

@dkwingsmt dkwingsmt closed this Nov 8, 2022
@dkwingsmt dkwingsmt deleted the backing-store-and-compositor branch November 8, 2022 22:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant