-
Notifications
You must be signed in to change notification settings - Fork 6k
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
I could probably write a test for this if we think this is something worth testing. |
Will this affect DevTools? @kenzieschmoll |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing the string VsyncSchedulingOverhead
in the framework tree anywhere, so if DevTools isn't using it, I think it's safe to remove.
LGTM from DevTools perspective. This change will not affect our tracing logic. Thank you for the tag @zanderso. |
Co-authored-by: Jonah Williams <[email protected]>
auto label is removed for flutter/engine, pr: 36982, due to - The status or check suite Linux Unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto label is removed for flutter/engine, pr: 36982, due to - The status or check suite Linux Unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
The formatter wants the comment whitespace to be fixed. |
VsyncSchedulingOverhead
event, since that event didn't always make sense - it records long scary bars in frames where the schedule frame did not originate from the framework, and it's not clear to me how this is useful to our users - see FrameTiming build start timestamp fix and add vsync start timestamp #20229Frame Request pending
if we're going to callBeginFrame
.Fixes flutter/flutter#113957