Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Cleanup animator tracing #36982

Merged
merged 3 commits into from
Oct 26, 2022
Merged

Cleanup animator tracing #36982

merged 3 commits into from
Oct 26, 2022

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Oct 24, 2022

  • Removes the VsyncSchedulingOverhead event, since that event didn't always make sense - it records long scary bars in frames where the schedule frame did not originate from the framework, and it's not clear to me how this is useful to our users - see FrameTiming build start timestamp fix and add vsync start timestamp #20229
  • Only emit Frame Request pending if we're going to call BeginFrame.
  • Emit an event when we re-use the last layer tree.

Fixes flutter/flutter#113957

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@dnfield
Copy link
Contributor Author

dnfield commented Oct 24, 2022

I could probably write a test for this if we think this is something worth testing.

@zanderso
Copy link
Member

Will this affect DevTools? @kenzieschmoll

Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing the string VsyncSchedulingOverhead in the framework tree anywhere, so if DevTools isn't using it, I think it's safe to remove.

@kenzieschmoll
Copy link
Member

LGTM from DevTools perspective. This change will not affect our tracing logic. Thank you for the tag @zanderso.

Co-authored-by: Jonah Williams <[email protected]>
@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 26, 2022
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 26, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 26, 2022

auto label is removed for flutter/engine, pr: 36982, due to - The status or check suite Linux Unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 26, 2022
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 26, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 26, 2022

auto label is removed for flutter/engine, pr: 36982, due to - The status or check suite Linux Unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@zanderso
Copy link
Member

The formatter wants the comment whitespace to be fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve tracing around frame scheduling
5 participants