Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix reply message race in FlutterWindowsEngineTest.PlatformMessageRoundTrip #37010

Closed

Conversation

jason-simmons
Copy link
Member

No description provided.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@gaaclarke
Copy link
Member

The correct fix is in #36909. I thought the failure would be consistent until the fix landed. Sorry about that. I'll pull the fix into its own pr and send it your way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants