Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Migrate darwin common "framework_shared" target to ARC (#37049)" #37121

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Revert "Migrate darwin common "framework_shared" target to ARC (#37049)" #37121

merged 1 commit into from
Oct 28, 2022

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Oct 28, 2022 •
edited
Loading

Reverts #37049 that causes a regression: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20channels_integration_test_ios/7695/overview

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

christopherfujino
christopherfujino approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@cyanglaz cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 28, 2022
@christopherfujino christopherfujino mentioned this pull request Oct 28, 2022
Closed
@auto-submit auto-submit bot merged commit 774cb34 into flutter:main Oct 28, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 28, 2022
@engine-flutter-autoroll
774cb34d3 Revert "Migrate darwin common "framework_shared" target to …
22574fd 
…ARC (flutter#37049)" (flutter/engine#37121)
@cyanglaz cyanglaz deleted the revert_37049 branch November 1, 2022 16:31
cyanglaz pushed a commit to cyanglaz/engine that referenced this pull request Nov 1, 2022
Revert "Revert "Migrate darwin common "framework_shared" target to ARC (
6280c40 
flutter#37049)" (flutter#37121)"

This reverts commit 774cb34.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-ios platform-macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyanglaz @christopherfujino