Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix typo in overlay platform view iOS test #37262

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Fix typo in overlay platform view iOS test #37262

merged 1 commit into from
Nov 4, 2022

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Nov 2, 2022

This was previously testing the same overlay view twice in a row. Instead, first test the first overlay size and then the second.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman requested a review from cyanglaz November 2, 2022 23:00
@jmagman jmagman self-assigned this Nov 2, 2022
jmagman
jmagman commented Nov 2, 2022
View reviewed changes
testing/scenario_app/ios/Scenarios/ScenariosUITests/UnobstructedPlatformViewTests.m
@@ -179,7 +179,7 @@ - (void)testOneOverlayAndTwoIntersectingOverlays {
XCTAssertEqualWithAccuracy(overlayView0.frame.size.height, app.frame.size.height,
kCompareAccuracy);

XCUIElement* overlayView1 = app.otherElements[@"platform_view[0].overlay_view[0]"];
XCUIElement* overlayView1 = app.otherElements[@"platform_view[0].overlay_view[1]"];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was previously the same as line 173:

  XCUIElement* overlayView0 = app.otherElements[@"platform_view[0].overlay_view[0]"];

cyanglaz
cyanglaz approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 4, 2022
@auto-submit auto-submit bot merged commit 5117e85 into flutter:main Nov 4, 2022
@jmagman jmagman deleted the overlay-typo branch November 4, 2022 18:37
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 4, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 4, 2022
@engine-flutter-autoroll
5117e858e Fix typo in overlay platform view iOS test (flutter/engine#…
75459d3 
…37262)
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this pull request Nov 4, 2022
flutter: 5117e858e Fix typo in overlay platform view iOS test (flutte…
cfe7892 
…r/engine#37262) (#114705)

Commit: be83c98edda77ee245764c264752fadf8f2cb8fa
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 4, 2022
@engine-flutter-autoroll
5117e858e Fix typo in overlay platform view iOS test (flutter/engine#…
be83c98 
…37262) (#114705)
This was referenced Nov 5, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2022
@engine-flutter-autoroll
be83c98 5117e858e Fix typo in overlay platform view iOS test (flutter…
f515665 
…/engine#37262) (flutter/flutter#114705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 5, 2022
@engine-flutter-autoroll
be83c98 5117e858e Fix typo in overlay platform view iOS test (flutter…
532373f 
…/engine#37262) (flutter/flutter#114705)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 5, 2022
@engine-flutter-autoroll
Roll Flutter from 55e8cd1 to e0e7027 (20 revisions) (#2782)
bf3328c 
* 77d6ecb 805b145d7 [web] Improve line breaker test exceptions (flutter/engine#37244) (flutter/flutter#114688)

* 5233fd9 Roll Plugins from 5c11747 to a279b9d (6 revisions) (flutter/flutter#114689)

* e1166e4 287a3ab59 Roll Skia from c901cb6ae66f to 1272b520c082 (1 revision) (flutter/engine#37314) (flutter/flutter#114691)

* 48457d7 WidgetController.startGesture trackpad support (flutter/flutter#114631)

* c1d2b85 Change some required nullable parameters in tool to non-null (flutter/flutter#114115)

* cfb2f15 Roll Flutter Engine from 287a3ab59269 to e947833ceb5b (2 revisions) (flutter/flutter#114696)

* 80bf355 Support keyboard selection in SelectabledRegion (flutter/flutter#112584)

* be83c98 5117e858e Fix typo in overlay platform view iOS test (flutter/engine#37262) (flutter/flutter#114705)

* 6ea01e6 Roll Flutter Engine from 5117e858ed1e to 6950689ed775 (3 revisions) (flutter/flutter#114710)

* b187bc4 Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (flutter/flutter#114637)

* 01507ba Revert "Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (#114637)" (flutter/flutter#114715)

* 91a56cf roll packages (flutter/flutter#114366)

* d68af26 Roll Flutter Engine from 6950689ed775 to 0933ca485a07 (3 revisions) (flutter/flutter#114714)

* 4fd0a92 Remove auto_cleanup of xcode caches. (flutter/flutter#114719)

* 96f9ca8 Roll Flutter Engine from 0933ca485a07 to 28e1ea0cc5b1 (4 revisions) (flutter/flutter#114720)

* 1aada6f [New Feature]Support mouse wheel event on the scrollbar widget (flutter/flutter#109659)

* 6265610 Roll Flutter Engine from 28e1ea0cc5b1 to ba390f2a7b7d (3 revisions) (flutter/flutter#114728)

* 140a57e Roll Flutter Engine from ba390f2a7b7d to 223a485ceb02 (3 revisions) (flutter/flutter#114732)

* 06ded49 Roll Flutter Engine from 223a485ceb02 to cf56eb5565e2 (3 revisions) (flutter/flutter#114735)

* e0e7027 9c45b0ebe Roll Fuchsia Mac SDK from jAKH68TYoKUA5HNS2... to Ua8Jtf8Zka9uxIVdl... (flutter/engine#37345) (flutter/flutter#114746)
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Nov 5, 2022
@engine-flutter-autoroll
Roll Flutter from 55e8cd1 to e0e7027 (20 revisions) (#6673)
f04ef73 
* 77d6ecb 805b145d7 [web] Improve line breaker test exceptions (flutter/engine#37244) (flutter/flutter#114688)

* 5233fd9 Roll Plugins from 5c11747 to a279b9d (6 revisions) (flutter/flutter#114689)

* e1166e4 287a3ab59 Roll Skia from c901cb6ae66f to 1272b520c082 (1 revision) (flutter/engine#37314) (flutter/flutter#114691)

* 48457d7 WidgetController.startGesture trackpad support (flutter/flutter#114631)

* c1d2b85 Change some required nullable parameters in tool to non-null (flutter/flutter#114115)

* cfb2f15 Roll Flutter Engine from 287a3ab59269 to e947833ceb5b (2 revisions) (flutter/flutter#114696)

* 80bf355 Support keyboard selection in SelectabledRegion (flutter/flutter#112584)

* be83c98 5117e858e Fix typo in overlay platform view iOS test (flutter/engine#37262) (flutter/flutter#114705)

* 6ea01e6 Roll Flutter Engine from 5117e858ed1e to 6950689ed775 (3 revisions) (flutter/flutter#114710)

* b187bc4 Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (flutter/flutter#114637)

* 01507ba Revert "Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (#114637)" (flutter/flutter#114715)

* 91a56cf roll packages (flutter/flutter#114366)

* d68af26 Roll Flutter Engine from 6950689ed775 to 0933ca485a07 (3 revisions) (flutter/flutter#114714)

* 4fd0a92 Remove auto_cleanup of xcode caches. (flutter/flutter#114719)

* 96f9ca8 Roll Flutter Engine from 0933ca485a07 to 28e1ea0cc5b1 (4 revisions) (flutter/flutter#114720)

* 1aada6f [New Feature]Support mouse wheel event on the scrollbar widget (flutter/flutter#109659)

* 6265610 Roll Flutter Engine from 28e1ea0cc5b1 to ba390f2a7b7d (3 revisions) (flutter/flutter#114728)

* 140a57e Roll Flutter Engine from ba390f2a7b7d to 223a485ceb02 (3 revisions) (flutter/flutter#114732)

* 06ded49 Roll Flutter Engine from 223a485ceb02 to cf56eb5565e2 (3 revisions) (flutter/flutter#114735)

* e0e7027 9c45b0ebe Roll Fuchsia Mac SDK from jAKH68TYoKUA5HNS2... to Ua8Jtf8Zka9uxIVdl... (flutter/engine#37345) (flutter/flutter#114746)
IVLIVS-III pushed a commit to IVLIVS-III/flutter_plugins_fork that referenced this pull request Nov 11, 2022
@engine-flutter-autoroll @IVLIVS-III
Roll Flutter from 55e8cd1 to e0e7027 (20 revisions) (flutter#6673)
ad466d6 
* 77d6ecb 805b145d7 [web] Improve line breaker test exceptions (flutter/engine#37244) (flutter/flutter#114688)

* 5233fd9 Roll Plugins from 5c11747 to a279b9d (6 revisions) (flutter/flutter#114689)

* e1166e4 287a3ab59 Roll Skia from c901cb6ae66f to 1272b520c082 (1 revision) (flutter/engine#37314) (flutter/flutter#114691)

* 48457d7 WidgetController.startGesture trackpad support (flutter/flutter#114631)

* c1d2b85 Change some required nullable parameters in tool to non-null (flutter/flutter#114115)

* cfb2f15 Roll Flutter Engine from 287a3ab59269 to e947833ceb5b (2 revisions) (flutter/flutter#114696)

* 80bf355 Support keyboard selection in SelectabledRegion (flutter/flutter#112584)

* be83c98 5117e858e Fix typo in overlay platform view iOS test (flutter/engine#37262) (flutter/flutter#114705)

* 6ea01e6 Roll Flutter Engine from 5117e858ed1e to 6950689ed775 (3 revisions) (flutter/flutter#114710)

* b187bc4 Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (flutter/flutter#114637)

* 01507ba Revert "Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (#114637)" (flutter/flutter#114715)

* 91a56cf roll packages (flutter/flutter#114366)

* d68af26 Roll Flutter Engine from 6950689ed775 to 0933ca485a07 (3 revisions) (flutter/flutter#114714)

* 4fd0a92 Remove auto_cleanup of xcode caches. (flutter/flutter#114719)

* 96f9ca8 Roll Flutter Engine from 0933ca485a07 to 28e1ea0cc5b1 (4 revisions) (flutter/flutter#114720)

* 1aada6f [New Feature]Support mouse wheel event on the scrollbar widget (flutter/flutter#109659)

* 6265610 Roll Flutter Engine from 28e1ea0cc5b1 to ba390f2a7b7d (3 revisions) (flutter/flutter#114728)

* 140a57e Roll Flutter Engine from ba390f2a7b7d to 223a485ceb02 (3 revisions) (flutter/flutter#114732)

* 06ded49 Roll Flutter Engine from 223a485ceb02 to cf56eb5565e2 (3 revisions) (flutter/flutter#114735)

* e0e7027 9c45b0ebe Roll Fuchsia Mac SDK from jAKH68TYoKUA5HNS2... to Ua8Jtf8Zka9uxIVdl... (flutter/engine#37345) (flutter/flutter#114746)
schwa423 pushed a commit to schwa423/engine that referenced this pull request Nov 16, 2022
@jmagman @schwa423
Fix typo in overlay platform view iOS test (flutter#37262)
8763366
percula pushed a commit to percula/packages that referenced this pull request Nov 17, 2022
@engine-flutter-autoroll @percula
Roll Flutter from 55e8cd1 to e0e7027 (20 revisions) (flutter#2782)
0e341bc 
* 77d6ecb 805b145d7 [web] Improve line breaker test exceptions (flutter/engine#37244) (flutter/flutter#114688)

* 5233fd9 Roll Plugins from 5c11747 to a279b9d (6 revisions) (flutter/flutter#114689)

* e1166e4 287a3ab59 Roll Skia from c901cb6ae66f to 1272b520c082 (1 revision) (flutter/engine#37314) (flutter/flutter#114691)

* 48457d7 WidgetController.startGesture trackpad support (flutter/flutter#114631)

* c1d2b85 Change some required nullable parameters in tool to non-null (flutter/flutter#114115)

* cfb2f15 Roll Flutter Engine from 287a3ab59269 to e947833ceb5b (2 revisions) (flutter/flutter#114696)

* 80bf355 Support keyboard selection in SelectabledRegion (flutter/flutter#112584)

* be83c98 5117e858e Fix typo in overlay platform view iOS test (flutter/engine#37262) (flutter/flutter#114705)

* 6ea01e6 Roll Flutter Engine from 5117e858ed1e to 6950689ed775 (3 revisions) (flutter/flutter#114710)

* b187bc4 Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (flutter/flutter#114637)

* 01507ba Revert "Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (#114637)" (flutter/flutter#114715)

* 91a56cf roll packages (flutter/flutter#114366)

* d68af26 Roll Flutter Engine from 6950689ed775 to 0933ca485a07 (3 revisions) (flutter/flutter#114714)

* 4fd0a92 Remove auto_cleanup of xcode caches. (flutter/flutter#114719)

* 96f9ca8 Roll Flutter Engine from 0933ca485a07 to 28e1ea0cc5b1 (4 revisions) (flutter/flutter#114720)

* 1aada6f [New Feature]Support mouse wheel event on the scrollbar widget (flutter/flutter#109659)

* 6265610 Roll Flutter Engine from 28e1ea0cc5b1 to ba390f2a7b7d (3 revisions) (flutter/flutter#114728)

* 140a57e Roll Flutter Engine from ba390f2a7b7d to 223a485ceb02 (3 revisions) (flutter/flutter#114732)

* 06ded49 Roll Flutter Engine from 223a485ceb02 to cf56eb5565e2 (3 revisions) (flutter/flutter#114735)

* e0e7027 9c45b0ebe Roll Fuchsia Mac SDK from jAKH68TYoKUA5HNS2... to Ua8Jtf8Zka9uxIVdl... (flutter/engine#37345) (flutter/flutter#114746)
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 21, 2022
@engine-flutter-autoroll
Roll Flutter from 55e8cd1 to e0e7027 (20 revisions) (flutter#6673)
854dd32 
* 77d6ecb 805b145d7 [web] Improve line breaker test exceptions (flutter/engine#37244) (flutter/flutter#114688)

* 5233fd9 Roll Plugins from 5c11747 to a279b9d (6 revisions) (flutter/flutter#114689)

* e1166e4 287a3ab59 Roll Skia from c901cb6ae66f to 1272b520c082 (1 revision) (flutter/engine#37314) (flutter/flutter#114691)

* 48457d7 WidgetController.startGesture trackpad support (flutter/flutter#114631)

* c1d2b85 Change some required nullable parameters in tool to non-null (flutter/flutter#114115)

* cfb2f15 Roll Flutter Engine from 287a3ab59269 to e947833ceb5b (2 revisions) (flutter/flutter#114696)

* 80bf355 Support keyboard selection in SelectabledRegion (flutter/flutter#112584)

* be83c98 5117e858e Fix typo in overlay platform view iOS test (flutter/engine#37262) (flutter/flutter#114705)

* 6ea01e6 Roll Flutter Engine from 5117e858ed1e to 6950689ed775 (3 revisions) (flutter/flutter#114710)

* b187bc4 Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (flutter/flutter#114637)

* 01507ba Revert "Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (#114637)" (flutter/flutter#114715)

* 91a56cf roll packages (flutter/flutter#114366)

* d68af26 Roll Flutter Engine from 6950689ed775 to 0933ca485a07 (3 revisions) (flutter/flutter#114714)

* 4fd0a92 Remove auto_cleanup of xcode caches. (flutter/flutter#114719)

* 96f9ca8 Roll Flutter Engine from 0933ca485a07 to 28e1ea0cc5b1 (4 revisions) (flutter/flutter#114720)

* 1aada6f [New Feature]Support mouse wheel event on the scrollbar widget (flutter/flutter#109659)

* 6265610 Roll Flutter Engine from 28e1ea0cc5b1 to ba390f2a7b7d (3 revisions) (flutter/flutter#114728)

* 140a57e Roll Flutter Engine from ba390f2a7b7d to 223a485ceb02 (3 revisions) (flutter/flutter#114732)

* 06ded49 Roll Flutter Engine from 223a485ceb02 to cf56eb5565e2 (3 revisions) (flutter/flutter#114735)

* e0e7027 9c45b0ebe Roll Fuchsia Mac SDK from jAKH68TYoKUA5HNS2... to Ua8Jtf8Zka9uxIVdl... (flutter/engine#37345) (flutter/flutter#114746)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
@engine-flutter-autoroll @shogohida
5117e858e Fix typo in overlay platform view iOS test (flutter/engine#…
69a070f 
…37262) (flutter#114705)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll @gspencergoog
5117e858e Fix typo in overlay platform view iOS test (flutter/engine#…
e297d09 
…37262) (flutter#114705)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@engine-flutter-autoroll @mauricioluz
Roll Flutter from 55e8cd1 to e0e7027 (20 revisions) (flutter#6673)
252434f 
* 77d6ecb 805b145d7 [web] Improve line breaker test exceptions (flutter/engine#37244) (flutter/flutter#114688)

* 5233fd9 Roll Plugins from 5c11747 to a279b9d (6 revisions) (flutter/flutter#114689)

* e1166e4 287a3ab59 Roll Skia from c901cb6ae66f to 1272b520c082 (1 revision) (flutter/engine#37314) (flutter/flutter#114691)

* 48457d7 WidgetController.startGesture trackpad support (flutter/flutter#114631)

* c1d2b85 Change some required nullable parameters in tool to non-null (flutter/flutter#114115)

* cfb2f15 Roll Flutter Engine from 287a3ab59269 to e947833ceb5b (2 revisions) (flutter/flutter#114696)

* 80bf355 Support keyboard selection in SelectabledRegion (flutter/flutter#112584)

* be83c98 5117e858e Fix typo in overlay platform view iOS test (flutter/engine#37262) (flutter/flutter#114705)

* 6ea01e6 Roll Flutter Engine from 5117e858ed1e to 6950689ed775 (3 revisions) (flutter/flutter#114710)

* b187bc4 Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (flutter/flutter#114637)

* 01507ba Revert "Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (#114637)" (flutter/flutter#114715)

* 91a56cf roll packages (flutter/flutter#114366)

* d68af26 Roll Flutter Engine from 6950689ed775 to 0933ca485a07 (3 revisions) (flutter/flutter#114714)

* 4fd0a92 Remove auto_cleanup of xcode caches. (flutter/flutter#114719)

* 96f9ca8 Roll Flutter Engine from 0933ca485a07 to 28e1ea0cc5b1 (4 revisions) (flutter/flutter#114720)

* 1aada6f [New Feature]Support mouse wheel event on the scrollbar widget (flutter/flutter#109659)

* 6265610 Roll Flutter Engine from 28e1ea0cc5b1 to ba390f2a7b7d (3 revisions) (flutter/flutter#114728)

* 140a57e Roll Flutter Engine from ba390f2a7b7d to 223a485ceb02 (3 revisions) (flutter/flutter#114732)

* 06ded49 Roll Flutter Engine from 223a485ceb02 to cf56eb5565e2 (3 revisions) (flutter/flutter#114735)

* e0e7027 9c45b0ebe Roll Fuchsia Mac SDK from jAKH68TYoKUA5HNS2... to Ua8Jtf8Zka9uxIVdl... (flutter/engine#37345) (flutter/flutter#114746)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyanglaz cyanglaz cyanglaz approved these changes

Assignees

@jmagman jmagman

Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmagman @cyanglaz