Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Update display_list_image_filter_unittests to be permit Skia roll #37327

Merged
merged 3 commits into from
Nov 8, 2022
Merged

Update display_list_image_filter_unittests to be permit Skia roll #37327

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
913c239
Update display_list_image_filter_unittests to be permit Skia roll
lhkbob Nov 4, 2022
eed6a73
Update comment to reference flutter issue.
lhkbob Nov 7, 2022
cc00a02
Merge branch 'flutter:main' into matrix-filter-test-fix
lhkbob Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions display_list/display_list_image_filter_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -810,8 +810,11 @@ TEST(DisplayListImageFilter, LocalImageFilterBounds) {
auto sk_local_filter = sk_filters[i]->makeWithLocalMatrix(m);
auto dl_local_filter = dl_filters[i]->makeWithLocalMatrix(m);
if (!sk_local_filter || !dl_local_filter) {
ASSERT_TRUE(!sk_local_filter);
ASSERT_TRUE(!dl_local_filter);
// Temporarily relax the equivalence testing to allow Skia to expand
// their behavior. Once the Skia fixes are rolled in, the
// DlImageFilter should adapt to the new rules.
// See https://github.com/flutter/flutter/issues/114723
ASSERT_TRUE(sk_local_filter || !dl_local_filter);
continue;
}
{
Expand Down