Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Apply the Windows friendly path solution for remaining ImpellerC paths #37344

Merged
merged 1 commit into from
Nov 6, 2022

Conversation

bdero
Copy link
Member

@bdero bdero commented Nov 5, 2022

Fixes new engine build issues I'm running into on Windows today:

[6880/7798] ACTION //flutter/lib/ui/fixtures/shaders/suppo...pile_supported_op_shaders(//build/toolchain/win:clang_x64)
FAILED: gen/flutter/lib/ui/fixtures/shaders/supported_op_shaders/iplr/145_OpMatrixTimesVector.frag.iplr
C:/Users/bdero/.vpython-root/cf506f/Scripts/python.exe ../../build/gn_run_binary.py impellerc.exe --input=../../flutter/lib/ui/fixtures/shaders/supported_op_shaders/145_OpMatrixTimesVector.frag --include=../../flutter/lib/ui/fixtures/shaders/supported_op_shaders --include=C:/Users/bdero/projects/flutter/engine/src/flutter/impeller/compiler/shader_lib --depfile=gen/flutter/lib/ui/fixtures/shaders/supported_op_shaders/iplr/145_OpMatrixTimesVector.frag.d --sksl --sl=gen/flutter/lib/ui/fixtures/shaders/supported_op_shaders/iplr/145_OpMatrixTimesVector.frag.iplr --spirv=gen/flutter/lib/ui/fixtures/shaders/supported_op_shaders/iplr/145_OpMatrixTimesVector.frag.spirv --iplr
Could not figure out working directory.
Invalid flags specified.

ImpellerC is an offline shader processor and reflection engine.
---------------------------------------------------------------
Valid Argument are:
One of [ --metal-desktop --metal-ios --opengl-desktop --opengl-es --runtime-stage-gles --runtime-stage-metal --sksl --vulkan ]
--input=<glsl_file>
[optional] --input-kind={comp, frag, tesc, tese, vert, }
--sl=<sl_output_file>
--spirv=<spirv_output_file>
[optional] --iplr (causes --sl file to be emitted in iplr format)
[optional] --reflection-json=<reflection_json_file>
[optional] --reflection-header=<reflection_header_file>
[optional] --reflection-cc=<reflection_cc_file>
[optional,multiple] --include=<include_directory>
[optional,multiple] --define=<define>
[optional] --depfile=<depfile_path>
[optional] --json

[6881/7798] ACTION //flutter/lib/ui/fixtures/shaders/suppo...pile_supported_op_shaders(//build/toolchain/win:clang_x64)
FAILED: gen/flutter/lib/ui/fixtures/shaders/supported_op_shaders/iplr/167_OpLogicalAnd.frag.iplr
C:/Users/bdero/.vpython-root/cf506f/Scripts/python.exe ../../build/gn_run_binary.py impellerc.exe --input=../../flutter/lib/ui/fixtures/shaders/supported_op_shaders/167_OpLogicalAnd.frag --include=../../flutter/lib/ui/fixtures/shaders/supported_op_shaders --include=C:/Users/bdero/projects/flutter/engine/src/flutter/impeller/compiler/shader_lib --depfile=gen/flutter/lib/ui/fixtures/shaders/supported_op_shaders/iplr/167_OpLogicalAnd.frag.d --sksl --sl=gen/flutter/lib/ui/fixtures/shaders/supported_op_shaders/iplr/167_OpLogicalAnd.frag.iplr --spirv=gen/flutter/lib/ui/fixtures/shaders/supported_op_shaders/iplr/167_OpLogicalAnd.frag.spirv --iplr
Could not figure out working directory.
Invalid flags specified.

ImpellerC is an offline shader processor and reflection engine.
---------------------------------------------------------------
Valid Argument are:
One of [ --metal-desktop --metal-ios --opengl-desktop --opengl-es --runtime-stage-gles --runtime-stage-metal --sksl --vulkan ]
--input=<glsl_file>
[optional] --input-kind={comp, frag, tesc, tese, vert, }
--sl=<sl_output_file>
--spirv=<spirv_output_file>
[optional] --iplr (causes --sl file to be emitted in iplr format)
[optional] --reflection-json=<reflection_json_file>
[optional] --reflection-header=<reflection_header_file>
[optional] --reflection-cc=<reflection_cc_file>
[optional,multiple] --include=<include_directory>
[optional,multiple] --define=<define>
[optional] --depfile=<depfile_path>
[optional] --json

[7744/7798] STAMP obj/flutter/tools/font-subset/font-subset.stamp
ninja: build stopped: cannot make progress due to previous errors.

Replacing the working directory path alone works for the above, but I went ahead and just replaced the couple of other remaining paths/deleted the non-working utils.

@bdero bdero self-assigned this Nov 5, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@bdero bdero changed the title [Impeller] Apply the Windows friendly path solution in remaining ImpellerC spots [Impeller] Apply the Windows friendly path solution for remaining ImpellerC paths Nov 5, 2022
@bdero bdero merged commit 36cfa9e into flutter:main Nov 6, 2022
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this pull request Nov 6, 2022
…ing spots (flutter/engine#37344) (#114759)

Commit: b1509ed64f29fff9740187ac05f38c252d6e6c00
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 6, 2022
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Nov 6, 2022
* cef4c2a ICU Message Syntax Parser (flutter/flutter#112390)

* 07d3a64 0886c7d0b Narrow the scope of the Windows Android arm hack (flutter/engine#37125) (flutter/flutter#114751)

* cf0cd06 Mark new_gallery__transition_perf as non-flaky (flutter/flutter#114694)

* 5bc50c1 Fix macOS migration nothing-to-upgrade test (flutter/flutter#114703)

* b1509ed 36cfa9e68 Apply the Windows friendly path solution in remaining spots (flutter/engine#37344) (flutter/flutter#114759)

* b45e628 b8218eacc Roll Fuchsia Mac SDK from Ua8Jtf8Zka9uxIVdl... to sNXsQVxntMX8f42LE... (flutter/engine#37352) (flutter/flutter#114760)

* 5ea5a53 6f3018a72 Roll Skia from a34882309d04 to c3c31be8729b (1 revision) (flutter/engine#37358) (flutter/flutter#114765)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 7, 2022
* cef4c2a ICU Message Syntax Parser (flutter/flutter#112390)

* 07d3a64 0886c7d0b Narrow the scope of the Windows Android arm hack (flutter/engine#37125) (flutter/flutter#114751)

* cf0cd06 Mark new_gallery__transition_perf as non-flaky (flutter/flutter#114694)

* 5bc50c1 Fix macOS migration nothing-to-upgrade test (flutter/flutter#114703)

* b1509ed 36cfa9e68 Apply the Windows friendly path solution in remaining spots (flutter/engine#37344) (flutter/flutter#114759)

* b45e628 b8218eacc Roll Fuchsia Mac SDK from Ua8Jtf8Zka9uxIVdl... to sNXsQVxntMX8f42LE... (flutter/engine#37352) (flutter/flutter#114760)

* 5ea5a53 6f3018a72 Roll Skia from a34882309d04 to c3c31be8729b (1 revision) (flutter/engine#37358) (flutter/flutter#114765)
IVLIVS-III pushed a commit to IVLIVS-III/flutter_plugins_fork that referenced this pull request Nov 11, 2022
* cef4c2a ICU Message Syntax Parser (flutter/flutter#112390)

* 07d3a64 0886c7d0b Narrow the scope of the Windows Android arm hack (flutter/engine#37125) (flutter/flutter#114751)

* cf0cd06 Mark new_gallery__transition_perf as non-flaky (flutter/flutter#114694)

* 5bc50c1 Fix macOS migration nothing-to-upgrade test (flutter/flutter#114703)

* b1509ed 36cfa9e68 Apply the Windows friendly path solution in remaining spots (flutter/engine#37344) (flutter/flutter#114759)

* b45e628 b8218eacc Roll Fuchsia Mac SDK from Ua8Jtf8Zka9uxIVdl... to sNXsQVxntMX8f42LE... (flutter/engine#37352) (flutter/flutter#114760)

* 5ea5a53 6f3018a72 Roll Skia from a34882309d04 to c3c31be8729b (1 revision) (flutter/engine#37358) (flutter/flutter#114765)
schwa423 pushed a commit to schwa423/engine that referenced this pull request Nov 16, 2022
percula pushed a commit to percula/packages that referenced this pull request Nov 17, 2022
* cef4c2a ICU Message Syntax Parser (flutter/flutter#112390)

* 07d3a64 0886c7d0b Narrow the scope of the Windows Android arm hack (flutter/engine#37125) (flutter/flutter#114751)

* cf0cd06 Mark new_gallery__transition_perf as non-flaky (flutter/flutter#114694)

* 5bc50c1 Fix macOS migration nothing-to-upgrade test (flutter/flutter#114703)

* b1509ed 36cfa9e68 Apply the Windows friendly path solution in remaining spots (flutter/engine#37344) (flutter/flutter#114759)

* b45e628 b8218eacc Roll Fuchsia Mac SDK from Ua8Jtf8Zka9uxIVdl... to sNXsQVxntMX8f42LE... (flutter/engine#37352) (flutter/flutter#114760)

* 5ea5a53 6f3018a72 Roll Skia from a34882309d04 to c3c31be8729b (1 revision) (flutter/engine#37358) (flutter/flutter#114765)
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 21, 2022
* cef4c2a ICU Message Syntax Parser (flutter/flutter#112390)

* 07d3a64 0886c7d0b Narrow the scope of the Windows Android arm hack (flutter/engine#37125) (flutter/flutter#114751)

* cf0cd06 Mark new_gallery__transition_perf as non-flaky (flutter/flutter#114694)

* 5bc50c1 Fix macOS migration nothing-to-upgrade test (flutter/flutter#114703)

* b1509ed 36cfa9e68 Apply the Windows friendly path solution in remaining spots (flutter/engine#37344) (flutter/flutter#114759)

* b45e628 b8218eacc Roll Fuchsia Mac SDK from Ua8Jtf8Zka9uxIVdl... to sNXsQVxntMX8f42LE... (flutter/engine#37352) (flutter/flutter#114760)

* 5ea5a53 6f3018a72 Roll Skia from a34882309d04 to c3c31be8729b (1 revision) (flutter/engine#37358) (flutter/flutter#114765)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
* cef4c2a ICU Message Syntax Parser (flutter/flutter#112390)

* 07d3a64 0886c7d0b Narrow the scope of the Windows Android arm hack (flutter/engine#37125) (flutter/flutter#114751)

* cf0cd06 Mark new_gallery__transition_perf as non-flaky (flutter/flutter#114694)

* 5bc50c1 Fix macOS migration nothing-to-upgrade test (flutter/flutter#114703)

* b1509ed 36cfa9e68 Apply the Windows friendly path solution in remaining spots (flutter/engine#37344) (flutter/flutter#114759)

* b45e628 b8218eacc Roll Fuchsia Mac SDK from Ua8Jtf8Zka9uxIVdl... to sNXsQVxntMX8f42LE... (flutter/engine#37352) (flutter/flutter#114760)

* 5ea5a53 6f3018a72 Roll Skia from a34882309d04 to c3c31be8729b (1 revision) (flutter/engine#37358) (flutter/flutter#114765)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants