-
Notifications
You must be signed in to change notification settings - Fork 6k
Adding release_build:true property to windows builders. #37397
Conversation
This will run the specified jobs under the release builder recipe in dart-internal. Bug:b/232552448
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Gold has detected about 82 new digest(s) on patchset 1. |
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
Gold has detected about 1 new digest(s) on patchset 2. |
This will run the specified jobs under the release builder recipe in dart-internal. Bug:b/232552448
…115008) * de0b58e82 clang-tidy: added the ability to shard jobs (flutter/engine#37265) * 8aefb8b61 Roll Dart SDK from d97d5ad98893 to b22b36c0f52e (1 revision) (flutter/engine#37400) * 2f043090f Roll Skia from aef6d301c0b5 to 0c8127b3dd7d (6 revisions) (flutter/engine#37402) * dc7cb20ad Fix boolean json property. (flutter/engine#37403) * 512fa40b6 Adding release_build:true property to windows builders. (flutter/engine#37397) * 0af87071f Add test for image readback (flutter/engine#37401) * c6f26e035 Update display_list_image_filter_unittests to be permit Skia roll (flutter/engine#37327) * 4e9e97b4b Roll Skia from 0c8127b3dd7d to 8b19fb0f57d4 (1 revision) (flutter/engine#37409) * 42c2940ff Pass the correct name for gclient variables in ci.yaml (flutter/engine#37429) * 2e2a2fd97 Revert "Roll Skia from 0c8127b3dd7d to 8b19fb0f57d4 (1 revision) (#37409)" (flutter/engine#37430) * 02cb78905 Roll Fuchsia Mac SDK from sa5bVGimNo3JwLV27... to d4l6A1aPw6Z0YjxmA... (flutter/engine#37432) * c24ae1872 [web] Use v8BreakIterator where possible (flutter/engine#37317) * 306b0fe9c Add rects to accumulator rather than bounds (flutter/engine#37435) * c76035429 Roll Dart SDK from b22b36c0f52e to c15cdb978761 (2 revisions) (flutter/engine#37437)
This will run the specified jobs under the release builder recipe in dart-internal. Bug:b/232552448
…lutter#115008) * de0b58e82 clang-tidy: added the ability to shard jobs (flutter/engine#37265) * 8aefb8b61 Roll Dart SDK from d97d5ad98893 to b22b36c0f52e (1 revision) (flutter/engine#37400) * 2f043090f Roll Skia from aef6d301c0b5 to 0c8127b3dd7d (6 revisions) (flutter/engine#37402) * dc7cb20ad Fix boolean json property. (flutter/engine#37403) * 512fa40b6 Adding release_build:true property to windows builders. (flutter/engine#37397) * 0af87071f Add test for image readback (flutter/engine#37401) * c6f26e035 Update display_list_image_filter_unittests to be permit Skia roll (flutter/engine#37327) * 4e9e97b4b Roll Skia from 0c8127b3dd7d to 8b19fb0f57d4 (1 revision) (flutter/engine#37409) * 42c2940ff Pass the correct name for gclient variables in ci.yaml (flutter/engine#37429) * 2e2a2fd97 Revert "Roll Skia from 0c8127b3dd7d to 8b19fb0f57d4 (1 revision) (flutter#37409)" (flutter/engine#37430) * 02cb78905 Roll Fuchsia Mac SDK from sa5bVGimNo3JwLV27... to d4l6A1aPw6Z0YjxmA... (flutter/engine#37432) * c24ae1872 [web] Use v8BreakIterator where possible (flutter/engine#37317) * 306b0fe9c Add rects to accumulator rather than bounds (flutter/engine#37435) * c76035429 Roll Dart SDK from b22b36c0f52e to c15cdb978761 (2 revisions) (flutter/engine#37437)
…lutter#115008) * de0b58e82 clang-tidy: added the ability to shard jobs (flutter/engine#37265) * 8aefb8b61 Roll Dart SDK from d97d5ad98893 to b22b36c0f52e (1 revision) (flutter/engine#37400) * 2f043090f Roll Skia from aef6d301c0b5 to 0c8127b3dd7d (6 revisions) (flutter/engine#37402) * dc7cb20ad Fix boolean json property. (flutter/engine#37403) * 512fa40b6 Adding release_build:true property to windows builders. (flutter/engine#37397) * 0af87071f Add test for image readback (flutter/engine#37401) * c6f26e035 Update display_list_image_filter_unittests to be permit Skia roll (flutter/engine#37327) * 4e9e97b4b Roll Skia from 0c8127b3dd7d to 8b19fb0f57d4 (1 revision) (flutter/engine#37409) * 42c2940ff Pass the correct name for gclient variables in ci.yaml (flutter/engine#37429) * 2e2a2fd97 Revert "Roll Skia from 0c8127b3dd7d to 8b19fb0f57d4 (1 revision) (flutter#37409)" (flutter/engine#37430) * 02cb78905 Roll Fuchsia Mac SDK from sa5bVGimNo3JwLV27... to d4l6A1aPw6Z0YjxmA... (flutter/engine#37432) * c24ae1872 [web] Use v8BreakIterator where possible (flutter/engine#37317) * 306b0fe9c Add rects to accumulator rather than bounds (flutter/engine#37435) * c76035429 Roll Dart SDK from b22b36c0f52e to c15cdb978761 (2 revisions) (flutter/engine#37437)
This will run the specified jobs under the release builder recipe in dart-internal.
Bug:b/232552448
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.