This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Test harness fixes for Dart2Wasm. #37560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
joshualitt
force-pushed
the
harness-fixes
branch
from
083debd to
e563737
Compare
eyebrowsoffire
approved these changes
Nov 14, 2022
joshualitt
force-pushed
the
harness-fixes
branch
2 times, most recently
from
28c2de5 to
694b69c
Compare
|
test-exempt: is a test |
joshualitt
force-pushed
the
harness-fixes
branch
from
694b69c to
9aabb0a
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 15, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 15, 2022
…115395) * 3a622e17a Skip the skwasm unit test suite on Safari since it is flaky. (flutter/engine#37602) * f1206f265 [web] Test harness fixes. (flutter/engine#37560) * c628e1f26 Roll Fuchsia Mac SDK from 32kfSm94FGtJJeUjg... to gKyvwhUS3r6pTRfxx... (flutter/engine#37634) * af6e47f1d Removing some builds from mac release builder. (flutter/engine#37556)
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#115395) * 3a622e17a Skip the skwasm unit test suite on Safari since it is flaky. (flutter/engine#37602) * f1206f265 [web] Test harness fixes. (flutter/engine#37560) * c628e1f26 Roll Fuchsia Mac SDK from 32kfSm94FGtJJeUjg... to gKyvwhUS3r6pTRfxx... (flutter/engine#37634) * af6e47f1d Removing some builds from mac release builder. (flutter/engine#37556)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#115395) * 3a622e17a Skip the skwasm unit test suite on Safari since it is flaky. (flutter/engine#37602) * f1206f265 [web] Test harness fixes. (flutter/engine#37560) * c628e1f26 Roll Fuchsia Mac SDK from 32kfSm94FGtJJeUjg... to gKyvwhUS3r6pTRfxx... (flutter/engine#37634) * af6e47f1d Removing some builds from mac release builder. (flutter/engine#37556)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.