Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix "unexpected masked action" assertion crash #37584

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Fix "unexpected masked action" assertion crash #37584

merged 1 commit into from
Nov 14, 2022

Conversation

moffatman
Copy link
Contributor

@moffatman moffatman commented Nov 14, 2022 •
edited
Loading

In #34060 I changed a return -1 to an assertion, this was a mistake. The returning -1 was correct, the events with those values get filtered out in addPointerForIndex later on. It's the correct behaviour to skip events we don't understand rather than crashing.

Fixes #111068

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

dkwingsmt
dkwingsmt approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moffatman moffatman added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 14, 2022
@auto-submit auto-submit bot merged commit 8c73fff into flutter:main Nov 14, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 14, 2022
@engine-flutter-autoroll
8c73ffff5 Fix unexpected masked action (flutter/engine#37584)
39155a1
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 14, 2022
@engine-flutter-autoroll
Roll Flutter Engine from 1a79e8686036 to 8c73ffff5b6f (2 revisions) (#…
59e1edc 
…115302)

* 9cf107b19 Revert "Fix wrong `VSYNC` event (#36775)" (flutter/engine#37589)

* 8c73ffff5 Fix unexpected masked action (flutter/engine#37584)
schwa423 pushed a commit to schwa423/engine that referenced this pull request Nov 16, 2022
@moffatman @schwa423
Fix unexpected masked action (flutter#37584)
4b50e16
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
@engine-flutter-autoroll @shogohida
Roll Flutter Engine from 1a79e8686036 to 8c73ffff5b6f (2 revisions) (f…
1646f56 
…lutter#115302)

* 9cf107b19 Revert "Fix wrong `VSYNC` event (flutter#36775)" (flutter/engine#37589)

* 8c73ffff5 Fix unexpected masked action (flutter/engine#37584)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll @gspencergoog
Roll Flutter Engine from 1a79e8686036 to 8c73ffff5b6f (2 revisions) (f…
5f1aeef 
…lutter#115302)

* 9cf107b19 Revert "Fix wrong `VSYNC` event (flutter#36775)" (flutter/engine#37589)

* 8c73ffff5 Fix unexpected masked action (flutter/engine#37584)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flutter 3.3.0 Fatal Exception: java.lang.AssertionError: Unexpected masked action
2 participants
@moffatman @dkwingsmt