Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Skip the skwasm unit test suite on Safari since it is flaky. #37602

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Skip the skwasm unit test suite on Safari since it is flaky. #37602

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8144eca
Skip the skwasm unit test suite on Safari since it is flaky.
eyebrowsoffire Nov 14, 2022
d352143
Add TODO.
eyebrowsoffire Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/web_ui/dev/steps/run_tests_step.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,10 @@ class RunTestsStep implements PipelineStep {
testsPassed &= io.exitCode == 0;
}

if (sortedTests.skwasmTests.isNotEmpty) {
// TODO(jacksongardner): enable this test suite on safari
// For some reason, Safari is flaky when running the Skwasm test suite
// See https://github.com/flutter/flutter/issues/115312
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make it a // TODO so it is tracked by the tech debt tracker.

if (browserName != kSafari && sortedTests.skwasmTests.isNotEmpty) {
await _runTestBatch(
testFiles: sortedTests.skwasmTests,
renderer: Renderer.skwasm,
Expand Down