This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Clang tidy and web engine cherrypicks #37660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* clang-tidy: added the ability to shard jobs * added test * jenn feedback * hack ci to run as a shard to measure the time * tweak * fix hack * zach feedback * zach feedback 2 * removed stray async * moved to using sets for lookups * fixed typo in docstring * Revert "fix hack" This reverts commit 06a61a6. Revert "tweak" This reverts commit e7c58b1. Revert "hack ci to run as a shard to measure the time" This reverts commit e458963. * removed calls to map * turned the ci hack back on * Revert "turned the ci hack back on" This reverts commit 0d53794. * removed sync*
Clang-tidy: Fixed math on shard-id validator.
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
fluttergithubbot
approved these changes
Nov 16, 2022
* Adding `felt analyze` command that CI will run. * Remove some copypasta'd stuff. * Also remove code path from felt.dart that forces a rebuild if it doesn't detect the host_debug_unopt directory. * More cleanup of felt.bat for CI. * Fix typo in felt.bat.
* Run pub get before building host.dart. * We should call `pub get` for `web_ui` in the launcher script because felt itself needs it. However, we should let felt invoke `pub get` on `web_engine_tester` only as needed, not in the launcher script.
* Skip the skwasm unit test suite on Safari since it is flaky. * Add TODO.
flutter-dashboard
bot
added
the
platform-web
godofredoc
changed the title
* Remove felt snapshotting behavior. * Use `dart run`.
* Combine results of all the test batches. * Skip regressions * Use bool instead * remove unused var * skip fragment_program_test * Also skip GL context lost test * Transparent background test fails on Firefox and Safari * Skip other test in safari * Skip text test on firefox
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CP: 583c71c
CP: de0b58e
CP: 3a622e1
CP: f48be34
CP: 12dabe8
CP: 6563c58
CP: 31ee286
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.