This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS] Cleanup unnecessary references to Metal #37733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes a few unncessary references to Metal in the macOS embedder. Now that Metal is the only supported rendering implementation for the macOS embedder, specifying a class as a Metal variant is redundant. Issue: flutter/flutter#108304 Issue: flutter/flutter#114445
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 18, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 18, 2022
…115618) * 5471734f7 [macOS] Cleanup unnecessary references to Metal (flutter/engine#37733) * 39f546585 Fix CanvasKit path tests (flutter/engine#37635)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#115618) * 5471734f7 [macOS] Cleanup unnecessary references to Metal (flutter/engine#37733) * 39f546585 Fix CanvasKit path tests (flutter/engine#37635)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#115618) * 5471734f7 [macOS] Cleanup unnecessary references to Metal (flutter/engine#37733) * 39f546585 Fix CanvasKit path tests (flutter/engine#37635)
This was referenced Jan 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a few unncessary references to Metal in the macOS embedder. Now that Metal is the only supported rendering implementation for the macOS embedder, specifying a class as a Metal variant is redundant.
Issue: flutter/flutter#108304
Issue: flutter/flutter#114445
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.