This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Ignore keydown event for tab during IME composition #37753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
htoor3
changed the title
mdebbar
reviewed
Nov 23, 2022
There was a problem hiding this comment.
Thanks @htoor3 for fixing this issue!
cc @dkwingsmt in case we need to do something similar for the hardware keyboard.
htoor3
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 28, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 28, 2022
…116140) * a41c6ece2 Ignore keydown event for tab during IME composition (flutter/engine#37753) * f326b630d Roll Skia from 6f65f0631e5a to 4a4cfedd1c20 (6 revisions) (flutter/engine#37942)
mit-mit
pushed a commit
to mit-mit/flutter
that referenced
this pull request
Dec 6, 2022
…lutter#116140) * a41c6ece2 Ignore keydown event for tab during IME composition (flutter/engine#37753) * f326b630d Roll Skia from 6f65f0631e5a to 4a4cfedd1c20 (6 revisions) (flutter/engine#37942)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#116140) * a41c6ece2 Ignore keydown event for tab during IME composition (flutter/engine#37753) * f326b630d Roll Skia from 6f65f0631e5a to 4a4cfedd1c20 (6 revisions) (flutter/engine#37942)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#116140) * a41c6ece2 Ignore keydown event for tab during IME composition (flutter/engine#37753) * f326b630d Roll Skia from 6f65f0631e5a to 4a4cfedd1c20 (6 revisions) (flutter/engine#37942)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During IME composition, Tab gets fired twice: once as part of the composition of the character and once without. This leads to unexpected behavior such as skipping a textfield during tab and input mutation. The solution is to ignore the keydown event that's a part of composition.
Fixes flutter/flutter#74813
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.