Revert "[impeller] Remove declare_undefined_values" #37831
Conversation
This reverts commit c3645c3.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Can you expand on this? This seems to remove an assertion check, which I assumed was fine to temporarily remove. |
No, the PR being reverted removes a line of code that emits declarations into the output SkSL. In a future version of spirv-cross, those declarations are emitted elsewhere, and this line of code will no longer be needed. But without rolling spirv-cross forward, those declarations would just be omitted and the emitted code would be incorrect. |
zanderso
added
the
autosubmit
…115842) * eba7ecddc Add setImageSampler (for replacing setSampler) (flutter/engine#37821) * 15dce5e11 Roll Skia from 57b4252cf211 to 550fd51bd254 (3 revisions) (flutter/engine#37830) * 9b07044e7 Revert "[impeller] Remove declare_undefined_values (#37829)" (flutter/engine#37831) * 1a6180869 Roll Dart SDK from 6b8e98070f26 to 27c45cd51796 (1 revision) (flutter/engine#37833) * 8bc415423 Roll Skia from 550fd51bd254 to 94c63addc990 (1 revision) (flutter/engine#37834) * 7b4291548 Roll Skia from 94c63addc990 to 0dec6d1823b3 (4 revisions) (flutter/engine#37836) * a7fa7c6ec Roll Fuchsia Linux SDK from xBfEjlXUsix6Wka-i... to 5Xd8MJTM-pWPWCgUa... (flutter/engine#37840) * b6e33b527 Roll Fuchsia Mac SDK from oaqX39ssn3PUxE9it... to mwKdD1jX_KVP1U76z... (flutter/engine#37844) * 37e2aaa90 Roll Skia from 0dec6d1823b3 to 3b2d9e4bf668 (1 revision) (flutter/engine#37845)
…lutter#115842) * eba7ecddc Add setImageSampler (for replacing setSampler) (flutter/engine#37821) * 15dce5e11 Roll Skia from 57b4252cf211 to 550fd51bd254 (3 revisions) (flutter/engine#37830) * 9b07044e7 Revert "[impeller] Remove declare_undefined_values (flutter#37829)" (flutter/engine#37831) * 1a6180869 Roll Dart SDK from 6b8e98070f26 to 27c45cd51796 (1 revision) (flutter/engine#37833) * 8bc415423 Roll Skia from 550fd51bd254 to 94c63addc990 (1 revision) (flutter/engine#37834) * 7b4291548 Roll Skia from 94c63addc990 to 0dec6d1823b3 (4 revisions) (flutter/engine#37836) * a7fa7c6ec Roll Fuchsia Linux SDK from xBfEjlXUsix6Wka-i... to 5Xd8MJTM-pWPWCgUa... (flutter/engine#37840) * b6e33b527 Roll Fuchsia Mac SDK from oaqX39ssn3PUxE9it... to mwKdD1jX_KVP1U76z... (flutter/engine#37844) * 37e2aaa90 Roll Skia from 0dec6d1823b3 to 3b2d9e4bf668 (1 revision) (flutter/engine#37845)
…lutter#115842) * eba7ecddc Add setImageSampler (for replacing setSampler) (flutter/engine#37821) * 15dce5e11 Roll Skia from 57b4252cf211 to 550fd51bd254 (3 revisions) (flutter/engine#37830) * 9b07044e7 Revert "[impeller] Remove declare_undefined_values (flutter#37829)" (flutter/engine#37831) * 1a6180869 Roll Dart SDK from 6b8e98070f26 to 27c45cd51796 (1 revision) (flutter/engine#37833) * 8bc415423 Roll Skia from 550fd51bd254 to 94c63addc990 (1 revision) (flutter/engine#37834) * 7b4291548 Roll Skia from 94c63addc990 to 0dec6d1823b3 (4 revisions) (flutter/engine#37836) * a7fa7c6ec Roll Fuchsia Linux SDK from xBfEjlXUsix6Wka-i... to 5Xd8MJTM-pWPWCgUa... (flutter/engine#37840) * b6e33b527 Roll Fuchsia Mac SDK from oaqX39ssn3PUxE9it... to mwKdD1jX_KVP1U76z... (flutter/engine#37844) * 37e2aaa90 Roll Skia from 0dec6d1823b3 to 3b2d9e4bf668 (1 revision) (flutter/engine#37845)
Reverts #37829
This breaks impellerc unless spirv-cross is also rolled forward.