This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove setSampler from FragmentShader #37839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
bdero
requested review from
jonahwilliams and
zanderso
and removed request for
jonahwilliams
zanderso
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
I think you're probably not missing anything. Unless @jonahwilliams knows of any other tests in the framework repo, I think the only usage of this API might have been for the ink sparkle shader, which doesn't use samplers.
|
Yeah, no usages I know of. Lgtm! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 22, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 23, 2022
…115881) * c05e7ff9b [Impeller] opt float/sampler into relaxed precision for gles (flutter/engine#37828) * 256dc78f6 Reland "[web] Avoid returning int from js interop classes." (flutter/engine#37627) * 5ab29c95a [web] Move unicode properties to third_party (flutter/engine#37440) * 10da1a1f0 Remove setSampler from FragmentShader (flutter/engine#37839) * a800e7650 [Impeller] make VerticesGeometry delegate to the DL class (flutter/engine#37835) * 1067cd2b7 Roll Skia from 3b2d9e4bf668 to 3bd2fe46f6d2 (2 revisions) (flutter/engine#37848) * 2d8e53925 change cloneImageElement() to return clone every time (flutter/engine#37811) * cefb954e0 fix pixel ratio (flutter/engine#37268) * c6b2ced1e Set nested clip nodes (flutter/engine#37850) * c7ecca866 Roll Skia from 3bd2fe46f6d2 to c098e3c5d932 (2 revisions) (flutter/engine#37851) * afac22d6c Made platform message responses threadsafe for macos. (flutter/engine#37607) * a805efffb fix docs analysis error on setImageSampler (flutter/engine#37852)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#115881) * c05e7ff9b [Impeller] opt float/sampler into relaxed precision for gles (flutter/engine#37828) * 256dc78f6 Reland "[web] Avoid returning int from js interop classes." (flutter/engine#37627) * 5ab29c95a [web] Move unicode properties to third_party (flutter/engine#37440) * 10da1a1f0 Remove setSampler from FragmentShader (flutter/engine#37839) * a800e7650 [Impeller] make VerticesGeometry delegate to the DL class (flutter/engine#37835) * 1067cd2b7 Roll Skia from 3b2d9e4bf668 to 3bd2fe46f6d2 (2 revisions) (flutter/engine#37848) * 2d8e53925 change cloneImageElement() to return clone every time (flutter/engine#37811) * cefb954e0 fix pixel ratio (flutter/engine#37268) * c6b2ced1e Set nested clip nodes (flutter/engine#37850) * c7ecca866 Roll Skia from 3bd2fe46f6d2 to c098e3c5d932 (2 revisions) (flutter/engine#37851) * afac22d6c Made platform message responses threadsafe for macos. (flutter/engine#37607) * a805efffb fix docs analysis error on setImageSampler (flutter/engine#37852)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#115881) * c05e7ff9b [Impeller] opt float/sampler into relaxed precision for gles (flutter/engine#37828) * 256dc78f6 Reland "[web] Avoid returning int from js interop classes." (flutter/engine#37627) * 5ab29c95a [web] Move unicode properties to third_party (flutter/engine#37440) * 10da1a1f0 Remove setSampler from FragmentShader (flutter/engine#37839) * a800e7650 [Impeller] make VerticesGeometry delegate to the DL class (flutter/engine#37835) * 1067cd2b7 Roll Skia from 3b2d9e4bf668 to 3bd2fe46f6d2 (2 revisions) (flutter/engine#37848) * 2d8e53925 change cloneImageElement() to return clone every time (flutter/engine#37811) * cefb954e0 fix pixel ratio (flutter/engine#37268) * c6b2ced1e Set nested clip nodes (flutter/engine#37850) * c7ecca866 Roll Skia from 3bd2fe46f6d2 to c098e3c5d932 (2 revisions) (flutter/engine#37851) * afac22d6c Made platform message responses threadsafe for macos. (flutter/engine#37607) * a805efffb fix docs analysis error on setImageSampler (flutter/engine#37852)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #37821.
I actually didn't find any setSampler usage in the framework, so just removing it before the engine roll finishes. 🤔 Am I missing anything?