Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[fuchsia] Update bug numbers #37880

Merged
merged 1 commit into from
Nov 24, 2022
Merged

[fuchsia] Update bug numbers #37880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shell/platform/fuchsia/flutter/engine.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,7 +744,7 @@ void Engine::Terminate() {
void Engine::DebugWireframeSettingsChanged(bool enabled) {
FML_CHECK(shell_);

// TODO(fxbug.dev/94000): Investigate if we can add flatland wireframe code
// TODO(fxbug.dev/116000): Investigate if we can add flatland wireframe code
// for debugging.
shell_->GetTaskRunners().GetRasterTaskRunner()->PostTask([this, enabled]() {
if (external_view_embedder_) {
Expand Down
6 changes: 3 additions & 3 deletions shell/platform/fuchsia/flutter/flatland_connection.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ void FlatlandConnection::DoPresent() {
--present_credits_;

fuchsia::ui::composition::PresentArgs present_args;
// TODO(fxbug.dev/94000): compute a better presentation time;
// TODO(fxbug.dev/114588): compute a better presentation time;
present_args.set_requested_presentation_time(0);
present_args.set_acquire_fences(std::move(acquire_fences_));
present_args.set_release_fences(std::move(previous_present_release_fences_));
Expand Down Expand Up @@ -86,7 +86,7 @@ void FlatlandConnection::AwaitVsync(FireCallbackCallback callback) {

if (threadsafe_state_.fire_callback_pending_) {
fml::TimePoint now = fml::TimePoint::Now();
// TODO(fxbug.dev/94000): Calculate correct frame times.
// TODO(fxbug.dev/114588): Calculate correct frame times.
threadsafe_state_.fire_callback_(
now, now + kDefaultFlatlandPresentationInterval);
threadsafe_state_.fire_callback_ = nullptr;
Expand Down Expand Up @@ -121,7 +121,7 @@ void FlatlandConnection::OnNextFrameBegin(
std::scoped_lock<std::mutex> lock(threadsafe_state_.mutex_);
if (threadsafe_state_.fire_callback_) {
fml::TimePoint now = fml::TimePoint::Now();
// TODO(fxbug.dev/94000): Calculate correct frame times.
// TODO(fxbug.dev/114588): Calculate correct frame times.
threadsafe_state_.fire_callback_(
now, now + kDefaultFlatlandPresentationInterval);
threadsafe_state_.fire_callback_ = nullptr;
Expand Down
2 changes: 0 additions & 2 deletions shell/platform/fuchsia/flutter/flatland_external_view_embedder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,8 +288,6 @@ void FlatlandExternalViewEmbedder::SubmitFrame(
viewport.mutators.transform = view_mutators.transform;
}

// TODO(fxbug.dev/94000): Set HitTestBehavior.

// Set clip regions.
if (view_mutators.clips != viewport.mutators.clips) {
// Expand the clip_transforms array to fit any new transforms.
Expand Down
2 changes: 1 addition & 1 deletion shell/platform/fuchsia/flutter/flatland_platform_view.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ void FlatlandPlatformView::OnGetLayout(

void FlatlandPlatformView::OnParentViewportStatus(
fuchsia::ui::composition::ParentViewportStatus status) {
// TODO(fxbug.dev/94000): Investigate if it is useful to send hidden/shown
// TODO(fxbug.dev/116001): Investigate if it is useful to send hidden/shown
// signals.
parent_viewport_status_ = status;
parent_viewport_watcher_->GetStatus(
Expand Down