This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add more missing includes of Skia headers #38398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjlubick
changed the title
chinmaygarde
approved these changes
Dec 19, 2022
chinmaygarde
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 38398, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead. |
|
auto label is removed for flutter/engine, pr: 38398, due to Validations Fail. |
zanderso
approved these changes
Dec 19, 2022
zanderso
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 19, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 19, 2022
…117336) * 290f3efc2 Add more missing includes (flutter/engine#38398) * 24a6a9183 Remove usage of SkToBool (flutter/engine#38401) * 725d47da2 reland: Started using FlutterEngineGroups by default on Android (flutter/engine#38367) * c7cc1b6f7 [Impeller Scene] Add animation/PBR descriptions to ipscene (flutter/engine#38397) * cba3a3990 Roll Skia from 46af4ad25426 to 8876daf17554 (3 revisions) (flutter/engine#38404)
loic-sharma
pushed a commit
to loic-sharma/flutter-engine
that referenced
this pull request
Jan 3, 2023
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#117336) * 290f3efc2 Add more missing includes (flutter/engine#38398) * 24a6a9183 Remove usage of SkToBool (flutter/engine#38401) * 725d47da2 reland: Started using FlutterEngineGroups by default on Android (flutter/engine#38367) * c7cc1b6f7 [Impeller Scene] Add animation/PBR descriptions to ipscene (flutter/engine#38397) * cba3a3990 Roll Skia from 46af4ad25426 to 8876daf17554 (3 revisions) (flutter/engine#38404)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to 3626c48 which adds more potentially-missing includes from display_list_matrix_clip_tracker.h
We are actively cleaning up our public API includes, and this aims to prevent future breakages.
Pre-launch Checklist
///).