This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Account for the transform in DLVerticesGeometry coverage #38998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Jan 19, 2023
|
D'oh |
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 19, 2023
zanderso
pushed a commit
to zanderso/engine
that referenced
this pull request
Jan 19, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 19, 2023
…118839) * f2536ce8d Shader analysis with malioc (flutter/engine#39005) * dd8c259bb [Impeller] Account for the transform in DLVerticesGeometry coverage (flutter/engine#38998) * 26b6609c6 Remove unused variables and import (flutter/engine#38971)
|
@zanderso I believe this is a cherry pick candidate as well. How do I kick start the process? |
|
@chinmaygarde I've already filed the request here flutter/flutter#118850 with the CP PR here #39014. If you can lgtm in both places, that will help =) |
|
Ah, I missed it. Thank you so much! 🙏🏽 |
CaseyHillers
pushed a commit
that referenced
this pull request
Jan 23, 2023
…age (#38998) (#39014) Co-authored-by: Brandon DeRosier <[email protected]>
ricardoamador
pushed a commit
to ricardoamador/engine
that referenced
this pull request
Jan 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happened across this bug while smoke testing Gallery.
Before:
After:
