This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Extract WideToUTF16String/UTF16StringToWide to FML" #39019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7bbe79e.
godofredoc
added
revert
auto-submit
bot
removed
the
revert
|
This pull request cannot be merged due to conflicts. Please resolve conflicts and re-add the revert label. |
godofredoc
added
the
revert
fluttergithubbot
approved these changes
Jan 20, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 20, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 20, 2023
…118869) * 7bbe79e10 Extract WideToUTF16String/UTF16StringToWide to FML (flutter/engine#39006) * acca56ce0 Revert "Extract WideToUTF16String/UTF16StringToWide to FML (#39006)" (flutter/engine#39019) * 730e88fb6 [Impeller] Check the correct stencil coverage when deciding whether to elide a restore (flutter/engine#39023)
|
LGTM thanks for reverting. This was caused by a race between two PRs: the one being reverted which removed the old function and another one that landed which added a new use of it. I've relanded this patch with the fix. |
ricardoamador
pushed a commit
to ricardoamador/engine
that referenced
this pull request
Jan 25, 2023
…9006)" (flutter#39019) This reverts commit 7bbe79e.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #39006