This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "[macOS] Formalize FlutterViewController's initialization flow… #39144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
approved these changes
Jan 25, 2023
dkwingsmt
added a commit
to dkwingsmt/engine
that referenced
this pull request
Jan 25, 2023
…ion flow, and prohibit replacing (flutter#38981)" (flutter#39144)" This reverts commit 36db005.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2023
…ation flow, and prohibit replacing (flutter#38981)" (flutter/engine#39144)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 26, 2023
…119208) * e3b278239 [macOS] Formalize FlutterViewController's initialization flow, and prohibit replacing (flutter/engine#38981) * 36db005dd Revert "[macOS] Formalize FlutterViewController's initialization flow, and prohibit replacing (#38981)" (flutter/engine#39144) * a20609120 Roll buildroot (flutter/engine#39141) * 8f1e5dc1b Reland "[macOS] Formalize FlutterViewController's initialization flow, and prohibit replacing" (flutter/engine#39145)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert because a test added in #37870 is not compatible with this PR.
It's a simple fix, but I'll use a new PR anyway.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.