Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[macOS] Eliminate mirrors support #39694

Merged
merged 1 commit into from
Feb 17, 2023
Merged

[macOS] Eliminate mirrors support #39694

merged 1 commit into from
Feb 17, 2023

Conversation

cbracken
Copy link
Member

Support for using dart:mirrors has been deprecated for nearly two years. this removes support for enabling mirrors from the embedder as documented in the deprecation comment. This was primarily added as a workaround for an internal tooling usecase, which no longer exists.

Issue: flutter/flutter#120924

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken
[macOS] Eliminate mirrors support
6c837a4 
Support for using dart:mirrors has been deprecated for nearly two years.
this removes support for enabling mirrors from the embedder as
documented in the deprecation comment. This was primarily added as a
workaround for an internal tooling usecase, which no longer exists.

Issue: flutter/flutter#120924
@cbracken cbracken requested review from dkwingsmt, loic-sharma and cyanglaz and removed request for loic-sharma February 17, 2023 00:41
loic-sharma
loic-sharma approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbracken cbracken merged commit 650db7a into flutter:main Feb 17, 2023
@cbracken cbracken deleted the remove-mirrors-support branch February 17, 2023 01:23
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2023
@engine-flutter-autoroll
650db7a72 [macOS] Eliminate mirrors support (flutter/engine#39694)
32d0572
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 17, 2023
@engine-flutter-autoroll
650db7a72 [macOS] Eliminate mirrors support (flutter/engine#39694) (#…
081cd57 
…120943)
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this pull request Feb 17, 2023
flutter: 650db7a72 [macOS] Eliminate mirrors support (flutter/engine#…
3a22954 
…39694) (#120943)

Commit: 081cd57765e9988eb797b67958993003c521a8a6
This was referenced Feb 17, 2023
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2023
@engine-flutter-autoroll
081cd57 650db7a72 [macOS] Eliminate mirrors support (flutter/engine#3…
5093ffc 
…9694) (flutter/flutter#120943)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 17, 2023
@engine-flutter-autoroll
081cd5776 650db7a72 [macOS] Eliminate mirrors support (flutter/engine…
96f83a8 
…#39694) (flutter/flutter#120943)
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Feb 17, 2023
@engine-flutter-autoroll
Roll Flutter from 22e17bb71050 to 298d8c76ba78 (20 revisions) (#7190)
8f3419b 
* f85438bfa c8b1d2ffa Roll Fuchsia Mac SDK from YpQKlqmyn8r_snx06... to xl9Y8o-9FDyvPogki... (flutter/engine#39675) (flutter/flutter#120887)

* 174a562a6 d699b4a Roll Flutter from e3471f0 to df41e58f6f4e (83 revisions) (#7184) (flutter/flutter#120888)

* 170539f83 Roll Flutter Engine from c8b1d2ffaec8 to 0d8d93306822 (2 revisions) (flutter/flutter#120891)

* df98689c9 2be7253c9 Roll Fuchsia Linux SDK from q7u2WyX2BSRBIzyTW... to yT4JLKTCWWwbRwB0l... (flutter/engine#39679) (flutter/flutter#120898)

* cacef57b6 [flutter_tools] Skip over "Resolving dependencies..." text in integration tests (flutter/flutter#120077)

* 34102ca3b Migrate channels to pkg:integration _test (flutter/flutter#120833)

* df13ea248 Roll Flutter Engine from 2be7253c9b10 to e4cb80e22ee1 (2 revisions) (flutter/flutter#120903)

* a2e65f7c3 Roll Flutter Engine from e4cb80e22ee1 to 4a90fbcd6901 (2 revisions) (flutter/flutter#120911)

* e00241a06 Enable Windows plugin tests (flutter/flutter#119345)

* 09ad9f3cd Document ScrollPhysics invariant requiring ballistic motion (flutter/flutter#120400)

* 6029de2fb Update switch template (flutter/flutter#120919)

* 229d70ea3 Roll Flutter Engine from 4a90fbcd6901 to bddfc1c4dcaa (5 revisions) (flutter/flutter#120920)

* 206c6ae99 roll packages (flutter/flutter#120922)

* 9fcaaebb5 Roll Flutter Engine from bddfc1c4dcaa to 6602fc753525 (3 revisions) (flutter/flutter#120928)

* 00c0a07fa Increase Linux docs_test timeout (flutter/flutter#120899)

* e29a79975 946b29198 [dart:ui] Introduce `PlatformDispatcher.implicitView` (flutter/engine#39553) (flutter/flutter#120939)

* 081cd5776 650db7a72 [macOS] Eliminate mirrors support (flutter/engine#39694) (flutter/flutter#120943)

* 875e48c69 52a4fb4c5 Roll Skia from b1800a8b9595 to d0df677ffd5e (13 revisions) (flutter/engine#39699) (flutter/flutter#120947)

* 78d058f46 6e92c0c28 Roll Fuchsia Mac SDK from xl9Y8o-9FDyvPogki... to haDvcC5VzWVdQs9Rs... (flutter/engine#39700) (flutter/flutter#120950)

* 298d8c76b Revert "Remove references to Observatory (#118577)" (flutter/flutter#120929)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2023
@engine-flutter-autoroll
081cd57 650db7a72 [macOS] Eliminate mirrors support (flutter/engine#3…
60c67b0 
…9694) (flutter/flutter#120943)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2023
@engine-flutter-autoroll
081cd57 650db7a72 [macOS] Eliminate mirrors support (flutter/engine#3…
3efaec1 
…9694) (flutter/flutter#120943)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2023
@engine-flutter-autoroll
081cd57 650db7a72 [macOS] Eliminate mirrors support (flutter/engine#3…
8ace920 
…9694) (flutter/flutter#120943)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2023
@engine-flutter-autoroll
081cd57 650db7a72 [macOS] Eliminate mirrors support (flutter/engine#3…
1924540 
…9694) (flutter/flutter#120943)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2023
@engine-flutter-autoroll
081cd57 650db7a72 [macOS] Eliminate mirrors support (flutter/engine#3…
43d4d90 
…9694) (flutter/flutter#120943)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 18, 2023
@engine-flutter-autoroll
Roll Flutter from 170539f to 0be7c3f (38 revisions) (#3225)
ce9c61b 
* df98689 2be7253c9 Roll Fuchsia Linux SDK from q7u2WyX2BSRBIzyTW... to yT4JLKTCWWwbRwB0l... (flutter/engine#39679) (flutter/flutter#120898)

* cacef57 [flutter_tools] Skip over "Resolving dependencies..." text in integration tests (flutter/flutter#120077)

* 34102ca Migrate channels to pkg:integration _test (flutter/flutter#120833)

* df13ea2 Roll Flutter Engine from 2be7253c9b10 to e4cb80e22ee1 (2 revisions) (flutter/flutter#120903)

* a2e65f7 Roll Flutter Engine from e4cb80e22ee1 to 4a90fbcd6901 (2 revisions) (flutter/flutter#120911)

* e00241a Enable Windows plugin tests (flutter/flutter#119345)

* 09ad9f3 Document ScrollPhysics invariant requiring ballistic motion (flutter/flutter#120400)

* 6029de2 Update switch template (flutter/flutter#120919)

* 229d70e Roll Flutter Engine from 4a90fbcd6901 to bddfc1c4dcaa (5 revisions) (flutter/flutter#120920)

* 206c6ae roll packages (flutter/flutter#120922)

* 9fcaaeb Roll Flutter Engine from bddfc1c4dcaa to 6602fc753525 (3 revisions) (flutter/flutter#120928)

* 00c0a07 Increase Linux docs_test timeout (flutter/flutter#120899)

* e29a799 946b29198 [dart:ui] Introduce `PlatformDispatcher.implicitView` (flutter/engine#39553) (flutter/flutter#120939)

* 081cd57 650db7a72 [macOS] Eliminate mirrors support (flutter/engine#39694) (flutter/flutter#120943)

* 875e48c 52a4fb4c5 Roll Skia from b1800a8b9595 to d0df677ffd5e (13 revisions) (flutter/engine#39699) (flutter/flutter#120947)

* 78d058f 6e92c0c28 Roll Fuchsia Mac SDK from xl9Y8o-9FDyvPogki... to haDvcC5VzWVdQs9Rs... (flutter/engine#39700) (flutter/flutter#120950)

* 298d8c7 Revert "Remove references to Observatory (#118577)" (flutter/flutter#120929)

* 674254c Always use the testbed in web_test.dart so `environment` is populated. (flutter/flutter#120984)

* c4d40cc Modify the updateChildren method deep copy _children (flutter/flutter#120773)

* 9367641 clean up (flutter/flutter#120934)

* 51712b9 Roll Plugins from d699b4a to 8f3419b (7 revisions) (flutter/flutter#120993)

* c3587c6 Add `InheritedTheme` support  to `ScrollbarTheme` (flutter/flutter#120970)

* 08b409a Roll Flutter Engine from 6e92c0c28410 to bd37a3992b50 (16 revisions) (flutter/flutter#121004)

* f785136 [web] Temporarily disable a line boundary test (flutter/flutter#121005)

* 9fe5567 Print sub process that failed to run in tool (flutter/flutter#120999)

* 6205c11 Remove "note that" in our documentation (as per style guide) (flutter/flutter#120842)

* 1daa0be Fix scrollable to clear inner semantics node if it does not use two p… (flutter/flutter#120996)

* 7f19b74 0a27673d7 Roll Skia from 02890036028e to 0e444e355607 (9 revisions) (flutter/engine#39723) (flutter/flutter#121008)

* 48d2dfc e7fde3f72 [web] Make glassPaneElement and glassPaneShadow non-nullable (flutter/engine#39692) (flutter/flutter#121009)

* 6104505 2b2780185 Roll Skia from 0e444e355607 to 4b79e398dfe0 (5 revisions) (flutter/engine#39725) (flutter/flutter#121016)

* f99f472 Remove the deprecated accentColor from ThemeData (flutter/flutter#120932)

* 2b4c960 Remove more references to dart:ui.window (flutter/flutter#120994)

* 0fa6527 Roll Flutter Engine from 2b2780185dd5 to a37e27b77008 (2 revisions) (flutter/flutter#121020)

* 9281114 Roll Flutter Engine from a37e27b77008 to 2fdce9a96367 (2 revisions) (flutter/flutter#121023)

* 4dd555d Roll Flutter Engine from 2fdce9a96367 to 9a3c3e462fce (3 revisions) (flutter/flutter#121025)

* 66dce65 Roll Flutter Engine from 9a3c3e462fce to 3777ed51774f (2 revisions) (flutter/flutter#121029)

* a5b53a6 a9db42c3e Roll Skia from 733a19f6a625 to 2f05923f825e (3 revisions) (flutter/engine#39744) (flutter/flutter#121030)

* 0be7c3f Roll Flutter Engine from a9db42c3edc2 to c22c64812243 (2 revisions) (flutter/flutter#121041)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
081cd57 650db7a72 [macOS] Eliminate mirrors support (flutter/engine#3…
ac564f9 
…9694) (flutter/flutter#120943)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
081cd57 650db7a72 [macOS] Eliminate mirrors support (flutter/engine#3…
ba7603e 
…9694) (flutter/flutter#120943)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@loic-sharma loic-sharma loic-sharma approved these changes

@stuartmorgan-g stuartmorgan-g Awaiting requested review from stuartmorgan-g

@dkwingsmt dkwingsmt Awaiting requested review from dkwingsmt

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

Assignees
No one assigned
Labels
platform-macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbracken @loic-sharma