Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Unify scale param for path and path component computation. #40047

Merged
merged 2 commits into from
Mar 4, 2023

Conversation

luckysmg
Copy link
Contributor

@luckysmg luckysmg commented Mar 3, 2023

After #39917 landed, we compute vertex using scale.
But

.CreatePolyline(scale);
and
.CreatePolyline(scale);

pass scale to PathComponent.CreatePolyline but PathComponent using tolerance for it. So this PR is unify params they use and get correct result.

For test CanDrawArc

Before:

After:

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@luckysmg luckysmg self-assigned this Mar 3, 2023
@chinmaygarde chinmaygarde changed the title Unify scale param for path and path component computation. [Impeller] Unify scale param for path and path component computation. Mar 4, 2023
@chinmaygarde
Copy link
Member

I just noticed it today. Was delightful to know it was fixed before I did :)

@luckysmg
Copy link
Contributor Author

luckysmg commented Mar 4, 2023

^_^

@luckysmg luckysmg added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 4, 2023
@auto-submit auto-submit bot merged commit 98e7e1c into flutter:main Mar 4, 2023
@luckysmg luckysmg deleted the path_component_scale branch March 4, 2023 08:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants