This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Round glyph locations per-run to fix per-glyph jitter #40073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The after video actually has zero visible per-glyph jitter in the runs, but the compression of the video compression is making it look a tiny bit jittery. |
bdero
force-pushed
the
bdero/fix-text-run-jitter
branch
from
ff9a559 to
64091e2
Compare
chinmaygarde
approved these changes
Mar 4, 2023
bdero
force-pushed
the
bdero/fix-text-run-jitter
branch
2 times, most recently
from
7836078 to
fe2ea5b
Compare
bdero
force-pushed
the
bdero/fix-text-run-jitter
branch
from
fe2ea5b to
7cffa79
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 6, 2023
sourcegraph-bot
pushed a commit
to sgtest/megarepo
that referenced
this pull request
Mar 6, 2023
…r-glyph jitter (flutter/engine#40073) (#122002) Commit: d940ec1f761404c849c23afa708c232d34f2a016
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 6, 2023
…itter (flutter/engine#40073) (#122002) Roll Flutter Engine from f8ec13dade7c to 197b6dae1c31 (1 revision)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves flutter/flutter#121531.
Round glyph positions relative to the text run origin so that individual characters in the run will snap to the pixel grid together. Note that as the atlas changes, there may still be a subpixel/antialiasing jitter, but this should be much less apparent than the full 1 pixel jitter that this patch fixes.
Before:
Screen.Recording.2023-03-03.at.5.19.32.PM.mov
After:
Screen.Recording.2023-03-03.at.5.21.15.PM.mov