Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Fix the test 'Play/DisplayListTest.CanDrawBackdropFilter/Metal' #40105

Merged
merged 1 commit into from
Mar 7, 2023
Merged

[Impeller] Fix the test 'Play/DisplayListTest.CanDrawBackdropFilter/Metal' #40105

merged 1 commit into from
Mar 7, 2023

Conversation

ColdPaleLight
Copy link
Member

@ColdPaleLight ColdPaleLight commented Mar 7, 2023 •
edited
Loading

fix flutter/flutter#122064

Related PR: #39762 which modified 'saveLayer' to 'SaveLayer'

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@ColdPaleLight ColdPaleLight self-assigned this Mar 7, 2023
dnfield
dnfield approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 7, 2023
@auto-submit auto-submit bot merged commit 0eefca4 into flutter:main Mar 7, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 7, 2023
@engine-flutter-autoroll
0eefca401 [Impeller] Fix the test 'Play/DisplayListTest.CanDrawBackdr…
27be9e6 
…opFilter/Metal' (flutter/engine#40105)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 7, 2023
@engine-flutter-autoroll
0eefca401 [Impeller] Fix the test 'Play/DisplayListTest.CanDrawBackdr…
5a7796a 
…opFilter/Metal' (flutter/engine#40105)
flar added a commit to flar/engine that referenced this pull request Mar 7, 2023
@flar
Revert "[Impeller] Fix the test 'Play/DisplayListTest.CanDrawBackdrop…
2032f91 
…Filter/Metal' (flutter#40105)"

This reverts commit 0eefca4.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dnfield dnfield dnfield approved these changes

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

Assignees

@ColdPaleLight ColdPaleLight

Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
No open projects
Impeller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Impeller] Play/DisplayListTest.CanDrawBackdropFilter/Metal is failing.
2 participants
@ColdPaleLight @dnfield