Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[roll + cherry pick] Fix imports for FlutterApplication (#40100) #40108

Conversation

XilaiZhang
Copy link
Contributor

Fix imports for FlutterApplication

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Fix imports for FlutterApplication
@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@XilaiZhang XilaiZhang requested a review from CaseyHillers March 7, 2023 05:41
@XilaiZhang
Copy link
Contributor Author

looks like engine auto roller still hasn't rolled the change to framework. will do an engine cherry pick

@XilaiZhang
Copy link
Contributor Author

windoes arm host engine failed 4 times in a row but i am pretty sure this is a flake

@XilaiZhang
Copy link
Contributor Author

will merge

@XilaiZhang XilaiZhang merged commit fd332d2 into flutter:flutter-3.9-candidate.2 Mar 7, 2023
@CaseyHillers
Copy link
Contributor

CaseyHillers commented Mar 7, 2023

@XilaiZhang you can skip presubmits on roll CPs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants